Skip to content

Prevent incorrect detection of AVA functions when accessing through "context" #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2019

Conversation

GMartigny
Copy link
Contributor

Add tests for all rules using "nameOfRootObject"
Fix #223

…context"

Add tests for all rules using "nameOfRootObject"
Fix avajs#223
@GMartigny
Copy link
Contributor Author

Hi,

I have not added tests to the assertion-message rule because it's deprecated and because I didn't want to add a hard-coded list of supported AVA functions.

I've also done a slight refactoring on util. If you don't want to include a refactoring to a fix, I'll gladly revert this part.

sindresorhus and others added 3 commits April 30, 2019 12:12
Follow suggestion

Co-Authored-By: GMartigny <[email protected]>
Fix `skip` assert position detection
Fix no-skip-assert unit tests
@sindresorhus sindresorhus merged commit 521d009 into avajs:master May 14, 2019
@GMartigny GMartigny deleted the avaFunctionDetection branch May 14, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect detection of properties of t.context as AVA functions
3 participants