chore: update golangci-lint

[RodrigoVillar]

While looking into Taskfiles for ffi, I noticed that we're still using golangci-lint v1 while AvalancheGo is already using golangci-lint v2. This PR upgrades the version of golangci-lint used in ffi to v2.

To maintain synchrony between the Firewood and AvalancheGo linter rules, an additional CI job (expected-golangci-yaml-diff) ensures that the difference between the two .golangci.yaml files is equal to the contents of golangci_yaml_expected_changes.txt.

What

• Copied over current AvalancheGo golangci.yml file and removing AvalancheGo-specific rules.
• Bumped version of golangci-lint action used in CI.
• Added expected-golangci-yaml-diff CI job
• Linted files

How This Was Tested

Ran golangci-lint locally + CI.

[rkuris]

Questions:

Is there any way to share the linter configuration between these two projects?
(if no) Can you provide a pointer to where this is being done in avalanchego so I can compare?
(if yes) let's do that instead!

[RodrigoVillar]

@rkuris I don't believe there's a way to share linter configs between the two projects.

Linter rules in AvalancheGo: https://github.com/ava-labs/avalanchego/blob/master/.golangci.yml

[rkuris]

@rkuris I don't believe there's a way to share linter configs between the two projects.

Linter rules in AvalancheGo: https://github.com/ava-labs/avalanchego/blob/master/.golangci.yml

I'm worried about them getting out of sync again. Possible solutions:

1 - Generate the golangci.yml file by fetching it from avalanchego's main and tweaking it before running the ci rule
2 - Add a new ci rule that verifies that it only contains the expected changes
3 - Use build.rs in the ffi directory to fetch avalanchego's rules and update them if necessary.

These are in order of preference.

[RodrigoVillar]

@rkuris I don't believe there's a way to share linter configs between the two projects.
Linter rules in AvalancheGo: https://github.com/ava-labs/avalanchego/blob/master/.golangci.yml

I'm worried about them getting out of sync again. Possible solutions:

1 - Generate the golangci.yml file by fetching it from avalanchego's main and tweaking it before running the ci rule 2 - Add a new ci rule that verifies that it only contains the expected changes 3 - Use build.rs in the ffi directory to fetch avalanchego's rules and update them if necessary.

These are in order of preference.

Went with the second option. The expected diff between the Firewood and AvalancheGo .golangci.yml files is now stored in golangci_yaml_expected_changes.txt and is verified by the expected-golangci-yaml-diff CI job: b7d7197

[rkuris]

Approved with nits

[alarso16]

Why remove the timeout?