Split action benchmark comparison and push to gh-pages #4130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the C-Chain benchmark workflow by properly splitting the benchmark comparison and archival processes into two distinct steps, ensuring that benchmark results are only pushed to the gh-pages branch from scheduled runs on the main branch.
- Replaces manual
git pushwith proper use of the benchmark action for pushing results - Adds pull request trigger for testing benchmark comparisons
- Separates comparison logic from archival logic using different action configurations
| @@ -60,7 +61,7 @@ jobs: | |||
| with: | |||
| path: ./cache | |||
| key: ${{ runner.os }}-reexecute-cchain-range-benchmark.json | |||
| - name: Compare Benchmark Results | |||
| - name: Compare Benchmark Result | |||
There was a problem hiding this comment.
[nitpick] The step name should be 'Compare Benchmark Results' (plural) to be consistent with the original naming and because it's comparing multiple benchmark results.
Suggested change
| - name: Compare Benchmark Result | |
| - name: Compare Benchmark Results |
Copilot uses AI. Check for mistakes.
maru-ava
approved these changes
Jul 28, 2025
StephenButtolph
approved these changes
Jul 28, 2025
joshua-kim
added a commit
that referenced
this pull request
Jul 30, 2025
commit 45df9e6 Author: Jonathan Oppenheimer <[email protected]> Date: Tue Jul 29 15:44:08 2025 -0400 chore: Update header year to 2025 (#4140) commit dca17fd Author: Stephen Buttolph <[email protected]> Date: Tue Jul 29 15:41:14 2025 -0400 Remove gitignore line that ignores the `database/dbtest` package (#4142) commit 6e56650 Author: aaronbuchwald <[email protected]> Date: Tue Jul 29 14:29:42 2025 -0400 Remove flaky dial throttler tests (#4139) commit 577820e Author: aaronbuchwald <[email protected]> Date: Tue Jul 29 13:25:27 2025 -0400 Add runner input to run c-chain reexecution benchmark on arbitrary target (#4121) Signed-off-by: aaronbuchwald <[email protected]> Co-authored-by: Copilot <[email protected]> commit d5cdc50 Author: Stephen Buttolph <[email protected]> Date: Tue Jul 29 13:24:13 2025 -0400 With golangci-lint v2.2.2 using http.NewRequest is discouraged (#4136) commit d9d6f59 Author: aaronbuchwald <[email protected]> Date: Tue Jul 29 11:49:26 2025 -0400 Remove external-data-json-path from benchmark push step (#4134) commit 0c62370 Author: aaronbuchwald <[email protected]> Date: Mon Jul 28 14:12:02 2025 -0400 Split action benchmark comparison and push to gh-pages (#4130) commit b1433fd Author: Geoff Stuart <[email protected]> Date: Fri Jul 25 14:50:16 2025 -0400 Enable Cubist Signer integration (#3965) Signed-off-by: Geoff Stuart <[email protected]> Signed-off-by: Joshua Kim <[email protected]> Co-authored-by: Richard Pringle <[email protected]> Co-authored-by: Joshua Kim <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]> commit 44c79a8 Author: rodrigo <[email protected]> Date: Fri Jul 25 10:52:17 2025 -0400 refactor: remove load 1.0 (#4112) commit e658cf4 Author: jishudashu <[email protected]> Date: Fri Jul 25 22:50:43 2025 +0800 refactor: use maps.Copy for cleaner map handling (#4119) Signed-off-by: jishudashu <[email protected]> commit 0980edf Author: aaronbuchwald <[email protected]> Date: Thu Jul 24 16:13:30 2025 -0400 Update codeowners of reexecution changes (#4116) commit 44b1e6c Author: Sam Liokumovich <[email protected]> Date: Thu Jul 24 16:00:45 2025 -0400 Simplex QuorumCertificate and BLS aggregator (#4091) commit 5af69e6 Author: rodrigo <[email protected]> Date: Thu Jul 24 13:17:48 2025 -0400 ci: remove load 1.0 (#4106) commit 12b75d4 Author: aaronbuchwald <[email protected]> Date: Wed Jul 23 13:01:42 2025 -0400 Add step to push benchmark results to gh-pages (#4103) Signed-off-by: aaronbuchwald <[email protected]> commit c712437 Author: Sam Liokumovich <[email protected]> Date: Wed Jul 23 11:33:29 2025 -0400 Remove Stale References of the toEngine Channel (#4101) Signed-off-by: Joshua Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the scheduled runs of pushing the C-Chain benchmark to
gh-pagesbranch by splitting comparison against the baseline and pushing to the branch into two separate steps.https://github.com/benchmark-action/github-action-benchmark/ suggests to only push results from the master branch to ensure data from stray feature branches doesn't get mistakenly added to tracking.
Previously, this attempted to follow the vague documentation of using
git push ...after running the action, which failed.This instead uses the action for both comparison and archiving to the branch by splitting it into two steps with a different set of options passed to each.