-
Notifications
You must be signed in to change notification settings - Fork 429
fix: correctly handle expired JWE's in cookies #2082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f3c4154
to
af39cb4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2082 +/- ##
==========================================
+ Coverage 84.23% 84.54% +0.31%
==========================================
Files 22 22
Lines 2208 2233 +25
Branches 397 406 +9
==========================================
+ Hits 1860 1888 +28
+ Misses 342 339 -3
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dff77c5
to
8dc270f
Compare
8dc270f
to
bdac51a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Any idea when this might make it into a release? Thanks in advance! |
Hi @frederikprijck |
📋 Changes
We ensured JWE's expire in #2040 , this has the side-effect that when an expired token hits the API, it would throw a 500 because it can not encrypt the JWE due to the expiration.
Instead of this, it should act as if there is no active session.
📎 References
#2081
🎯 Testing