-
Notifications
You must be signed in to change notification settings - Fork 66
Add support for credentials file #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
**Example:** | ||
|
||
```ini | ||
[default] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better if profiles can use common variable across profile
example:
[common]
tenant = your-tenant.auth0.com
[dev-profile-1]
client_id = YOUR_CLIENT_ID_1
client_secret = YOUR_CLIENT_SECRET_1
[dev-profile-2]
client_id = YOUR_DEV_CLIENT_ID_2
client_secret = YOUR_DEV_CLIENT_SECRET_2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- show the list of current profiles
--profile ls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
In most cases, we log in using different tenants, and each profile can correspond to a different tenant. So, I don't see much value in having a common one.
-
Profiles are manually stored locally by the user, so I see less benefit in supporting a list command just to view what they’ve explicitly added to their local file.
Besides, we already have thetenants ls
command to view currently logged-in tenants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Using common variable is a very standard and useful pattern example,
.gitconfig
(core) --profile ls
is or--profile <profile-name>
will improve cli experience.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
- Coverage 65.50% 65.38% -0.12%
==========================================
Files 108 108
Lines 16351 16390 +39
==========================================
+ Hits 10711 10717 +6
- Misses 4995 5025 +30
- Partials 645 648 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🔧 Changes
Add support to use tenant credentials details from the local file with the command :
auth0 login --profile <tenant-profile
📚 References
#1234
🔬 Testing
📝 Checklist