UPSTREAM PR #17637: vulkan: Replace deprecated VK_EXT_validation_features#383
UPSTREAM PR #17637: vulkan: Replace deprecated VK_EXT_validation_features#383loci-dev wants to merge 1 commit into
Conversation
|
Explore the complete analysis inside the Version Insights Performance Analysis Summary - PR #383Analysis OverviewThis PR modernizes Vulkan validation layer configuration by replacing the deprecated Performance ImpactPower Consumption Analysis: Function-Level Analysis: Inference Impact: Code Changes: |
3db03c6 to
82b3726
Compare
|
Explore the complete analysis inside the Version Insights Performance Analysis Summary: PR #383OverviewThis PR replaces the deprecated Vulkan extension Performance ImpactInference Performance: No impact. The modified functions
Tokens Per Second: No degradation expected. Since tokenization and inference functions show zero response time or throughput changes, the model performance remains identical to baseline. Power Consumption: Negligible change across all binaries. Measured impact <0.001% with build.bin.libllama.so showing +0.00025% (+0.48 nJ) variation, within measurement noise. The compiler generated functionally equivalent assembly code. Modified Functions:
Both functions execute outside inference hot paths and contribute zero overhead to token processing throughput. |
38683c7 to
fa6cdcc
Compare
84f6117 to
91eb894
Compare
Mirrored from ggml-org/llama.cpp#17637
When enabling
-DGGML_VULKAN_VALIDATE=ONI see lots of validation warnings cluttering the output. I want to remove at least one of them by replacingVK_EXT_validation_featureswithVK_EXT_layer_settings. This should also make it easier to enable the Debug Printf feature which makes debugging the shader much easier (at least for me)Before
After