-
Notifications
You must be signed in to change notification settings - Fork 1
Fix iso-639 Poetry Dependency Issues #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great, seems anyway a good idea to find a replacement for Did you do any comparison between https://github.com/LBeaudoux/iso639 and https://github.com/jacksonllee/iso639, or is it just random that you picked |
|
Currently, the tests fail with: Locally, I can reproduce the error. |
I have only looked at both of their READMEs and decided to go with https://github.com/LBeaudoux/iso639 as it was updated more recently.
Interesting, i am unable to reproduce this on Windows. Pretty sure this means that the wrong library is used. |
|
I tested locally under Linux.
When I start from an empty virtual environment, I don't get the error. Locally, I could reproduce the error as I first installed |
Exactly, also just verified that this is what happens. However the issue is that all packages use |
|
When running The problem is that then it runs For whatever reason it seems not satisfied with the dev version of |
|
It seems that when installing the dev version of It should instead be something like |
|
I fixed the CI job in #457 and merged it into |
7b802c6 to
1fdcded
Compare
|
Done. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
|
All looks fine now, thanks again for your contribution. I will merge now and later make a new |





There seems to be an issue with the
iso-639package in combination with Poetry (very similar to python-poetry/poetry#6996).Poetry is unable to determine the version of the package (see below), therefore
audformatas well as any packages that depend on it (likeopensmile) cannot be used in poetry projects.To reproduce, run
poetry lockfor the followingpyproject.toml:The workaround for local projects is to directly fetch the package from git:
However, this is not a viable solution for publishing on PyPI, i.e. no package can be published using poetry that depends on
audformat.This PR replaces
iso-639withiso639-langunder the hood to solve the dependency resolution.All tests are passing and running
poetry lockwith the updated dependency works like a charm.