-
Notifications
You must be signed in to change notification settings - Fork 242
Defeat mocha #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Defeat mocha #21
Conversation
|
@Munter Nice - I started on this, but gave up after looking at the API 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to require('../test/_fake-ci')
see #17 for ref
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Guria Thanks for helping out on the repo 😄 We've added you as a collaborator! 🎉
|
Shouldn't your travis build always be green? |
|
@drewnichols haha yeah - we should eat our own dog food as they say ;) |
|
@drewnichols @watson good point, but then we can miss a problem which can lead to failed tests of our users |
|
@Guria true - was only joking of cause 😉 But it is kind of funny that we have so good test coverage in a project aimed at not testing 😜 |
|
I don’t think the aim is to not test. It’s just to ensure that the our bosses never see the tests fail. — Drew Nichols VP of Engineering LiftForward, Inc. 261 Madison Avenue, 9th Floor New York, NY 10016 917-473-3006 On Tue, Oct 13, 2015 at 8:40 AM, Thomas Watson Steen
|
|
This is the most meta thing ever. |
|
Checks failed for this PR. Perhaps consider installing Volkswagen? |
|
any chance we can close this so it's off my view? |
|
We can disable the tests for the exports and require interfaces. It won't be a full defeat, but I've never seen even a single project use those two interfaces. Everyone seems to be using bdd or tdd |

Defeat mocha UI's: