Skip to content

fix: SSH connection sometimes doesn't read until EOF #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BinaryMuse merged 2 commits into from
Feb 3, 2026
Merged

fix: SSH connection sometimes doesn't read until EOF #375

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86c8ed9
Call exec_finished in SSH session when command fails to execute
BinaryMuse Jan 29, 2026
9857424
Don't stop reading data from SSH session until Eof arrives
BinaryMuse Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions crates/atuin-desktop-runtime/src/ssh/session.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,6 +1396,8 @@ impl Session {
let _ = output_stream_clone
.send(OutputLine::Stderr(e.to_string()))
.await;
tracing::debug!("Sending exec finished for channel {channel_id_clone}");
let _ = handle.exec_finished(&channel_id_clone).await;
return;
}

Expand Down Expand Up @@ -1450,9 +1452,12 @@ impl Session {
}
}
}
// ExitStatus signals the command's exit code but does NOT
// guarantee all Data messages have been delivered (RFC 4254
// §6.10). Only Eof guarantees no more data will follow.
// Continue reading until Eof or Close.
ChannelMsg::ExitStatus { .. } => {
tracing::trace!("Handling SSH ExitStatus message");
break;
tracing::trace!("Handling SSH ExitStatus message (continuing to read)");
}
ChannelMsg::Eof => {
tracing::trace!("Handling SSH EOF message");
Expand Down
Loading