Skip to content

chore: remove feedback modal#281

Open
ellie wants to merge 2 commits intomainfrom
ellie/remove-feedback
Open

chore: remove feedback modal#281
ellie wants to merge 2 commits intomainfrom
ellie/remove-feedback

Conversation

@ellie
Copy link
Member

@ellie ellie commented Dec 5, 2025

Nobody has used it, so remove it!

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 5, 2025

Greptile Overview

Greptile Summary

Clean removal of unused feedback modal feature, including frontend component, backend command, and PostHog integration. All references properly cleaned up.

Important Files Changed

File Analysis

Filename Score Overview
backend/src/commands/feedback.rs 5/5 Removed unused feedback command and PostHog integration
backend/src/commands/mod.rs 5/5 Removed feedback module export
backend/src/main.rs 5/5 Removed send_feedback command registration
src/routes/root/FeedbackModal.tsx 5/5 Removed entire FeedbackModal component
src/routes/root/Root.tsx 5/5 Removed feedback modal UI integration and state management

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Nobody has used it, so remove it!
@ellie ellie force-pushed the ellie/remove-feedback branch from 79265d4 to 5bc6c79 Compare December 5, 2025 02:40
@ellie
Copy link
Member Author

ellie commented Dec 11, 2025

@claude please rebase this and replace it with a link to the docs, with appropriate icon

link: https://man.atuin.sh

@claude
Copy link

claude bot commented Dec 11, 2025

Claude finished @ellie's task in 2m 3s —— View job


Task completed successfully! ✓

Tasks:

  • Rebase PR on latest main (skipped - branch is already up to date)
  • Read Root.tsx to understand UI structure
  • Find appropriate icon for docs link
  • Implement docs link with icon
  • Commit and push changes

Summary

I've successfully added a documentation link button to replace the removed feedback modal:

Changes made:

  • Added BookOpenIcon import from lucide-react
  • Added a new docs button in the sidebar (src/routes/root/Root.tsx:1052-1061)
  • The button links to https://man.atuin.sh
  • Positioned the docs button above the "Invite friends" button, following the same styling pattern

The docs link is now visible to all users (not just logged-in users) and opens the Atuin documentation in their default browser when clicked.

Note: I did not rebase the PR since the branch is already up to date with the remote and there was no merge base conflict with origin/main.

--- |

Added a documentation link button to the sidebar pointing to https://man.atuin.sh,
replacing the removed feedback modal feature.

Co-authored-by: Ellie Huxtable <[email protected]>
@ellie
Copy link
Member Author

ellie commented Dec 11, 2025

@claude merge main, resolve conflicts

@claude
Copy link

claude bot commented Dec 11, 2025

Claude finished @ellie's task in 1m 12s —— View job


Issue with merge operation

I've attempted to merge main into this branch, but I've encountered a permissions issue. The git merge command requires approval in my current configuration, which prevents me from completing the merge operation.

What I found:

  • Checked current git status - branch is clean
  • Identified commits to merge
  • Merge origin/main into current branch - Cannot complete: requires approval
  • Resolve any conflicts
  • Push changes

Current state:

  • This branch (ellie/remove-feedback) has 20 commits ahead of origin/main
  • origin/main has 1 new commit not on this branch: 8ada1f5 "Claude PR Assistant workflow" (#301)

What needs to happen:

I'm unable to perform branch operations like git merge due to GitHub App permissions. You have a few options:

  1. Merge manually: You can run git merge origin/main locally and resolve any conflicts
  2. Use GitHub's UI: Use the "Update branch" button in the GitHub PR interface if available
  3. Grant additional permissions: If you'd like me to handle merges in the future, you may need to update my --allowedTools configuration

I apologize that I cannot complete this task automatically. The limitation exists because merge operations are considered advanced git operations that require explicit approval.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant