fix(nu): avoid multiline keybinding commands - #3880
Open
mirsella wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryMoves Nushell search logic into Confidence Score: 5/5The PR appears safe to merge. The generated Ctrl-R and up-arrow commands match the two history-filter variants, and version-specific Nushell behavior remains selected at runtime. Important Files Changed
Reviews (1): Last reviewed commit: "fix(nu): avoid multiline keybinding comm..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nushell can expose the multiline source passed to
ExecuteHostCommand, which causes Atuin's generated command to appear in the command line and history.Move the search logic into
_atuin_searchand have the keybindings execute a single-line command. The per-shell token still distinguishes generated commands from manually entered ones, and exact matching keeps those commands out of Atuin history.The newer
commandline edit --acceptpath remains generated at runtime so the integration still parses on older supported Nushell versions.Fixes #2900.
Tested with:
cargo fmt --all -- --checkcargo +nightly test --locked -p atuin shell --quietnu-checkon Nushell 0.93.0 and 0.114.1