feat: add a bunch more secret patterns - #3872
Open
ellie wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryAdds secret-detection patterns and negative tests for commands that must remain in history.
Confidence Score: 4/5The ConfigMap false positive should be fixed before merging because it silently drops legitimate command history. The default-enabled filter classifies every Files Needing Attention: crates/atuin-client/src/secrets.rs Important Files Changed
Reviews (1): Last reviewed commit: "feat: add a bunch more secret patterns" | Re-trigger Greptile |
| // `kubectl create secret generic … --from-literal=…` puts the secret value | ||
| // straight on the command line. | ||
| "Kubernetes secret literal", | ||
| r"--from-literal[= ]", |
Contributor
Comment on lines
+259
to
+260
| #[cfg(test)] | ||
| static NON_SECRETS: &[&str] = &[ |
Member
There was a problem hiding this comment.
maybe move this into the tests module if it's only used by tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of these secrets are invalid. Shush scanners and agents.
Checks
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.