Fixed a lock-up on closing WnMM Midi devices #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the patch. It was code contributed by @noname22 so let me wait for any possible comments for a day-ish. If no problem is found then I will merge it. |
Owner
|
merging. Thanks again! |
atsushieno
added a commit
that referenced
this pull request
Dec 28, 2022
peppy
added a commit
to peppy/osu-framework
that referenced
this pull request
Sep 4, 2024
Pulls in atsushieno/managed-midi#74. Closes ppy#4486.
peppy
added a commit
to peppy/osu-framework
that referenced
this pull request
Sep 4, 2024
Pulls in atsushieno/managed-midi#74. Closes ppy#4486.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found and fixed an issue with WinMM midi devices not disposing / closing correctly due to lock contention of the "lockObject". This would delay closes by 10 seconds and possibly not clean up buffers correctly.