Skip to content

Conversation

ianrrees
Copy link
Contributor

This adds a defmt feature to our T1 BSPs (plus Grand Central M4, as groundwork for @supersimple33 's #902) which enables the HAL's defmt feature and sets the linker argument using build.rs.

I'm a little surprised this seems compatible with the use_rtt feature, inasmuch as the examples still build. @kyp44 if you have a minute, could you please have a look and see if this looks problematic?

Resolves #810

@ianrrees ianrrees force-pushed the bsp-defmt-feature branch from 392b874 to 80135bd Compare July 13, 2025 08:26
@sajattack
Copy link
Member

Great idea with the build.rs!

@ianrrees
Copy link
Contributor Author

ianrrees commented Jul 13, 2025

Before merging this, I'd like to add a comment about using DEFMT_LOG near to the defmt feature in Cargo.toml

@ianrrees ianrrees force-pushed the bsp-defmt-feature branch 2 times, most recently from bd17e3b to e0ec140 Compare July 13, 2025 19:36
@kyp44
Copy link
Contributor

kyp44 commented Jul 13, 2025

@ianrrees is there something specific you'd like me to look at? I don't use a debugger or defmt, so I am not really tracking any of this stuff.

@ianrrees
Copy link
Contributor Author

@ianrrees is there something specific you'd like me to look at? I don't use a debugger or defmt, so I am not really tracking any of this stuff.

Nothing specific, just noticed that git blame showed you as touching some lines to do with use_rtt

@kyp44
Copy link
Contributor

kyp44 commented Jul 19, 2025

@ianrrees I did not see this in the git blame, though I have never used that command before until now. I did touch lines related to the rtic feature since I worked on that. in any case, I haven't done any actual work on the use_rtt explicitly so I'm not familiar with it, though maybe at one point I had to touch something for some other reason.

@ianrrees ianrrees force-pushed the bsp-defmt-feature branch from e0ec140 to a2ee483 Compare July 21, 2025 02:57
@rnd-ash
Copy link
Contributor

rnd-ash commented Jul 30, 2025

@ianrrees I can't find anything wrong with this PR that might need correcting, it all looks good.

Potentially, yes, using RTT Serial and DEFMT could cause issues if used together, I might be able to test this later today and check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide defmt feature in BSPs, that enables atsamd-hal/defmt
4 participants