Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Corrected Quote syntax highlighting #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Down10
Copy link

@Down10 Down10 commented Feb 25, 2017

Changed quoted text to be read as markup text instead of comment text.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Changed syntax highlighting of quote text to correctly be read as markup text and not comment text.

Alternate Designs

None considered. Syntax matches that of other languages supported by Atom.

Benefits

Text will be highlighted correctly as quoted markup.

Possible Drawbacks

Text highlighting may render differently in custom Atom themes that were styled baed upon the previous incorrect syntax.

Applicable Issues

Addresses #185.

Changed quoted text to be read as markup text instead of comment text.
Copy link
Contributor

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd advise against this. I doubt there're many syntax themes which highlight the markup.quote scope, whereas the comment scope is more widely supported.

I think you'll find most of this grammar's scope-name choices are... strange and semantically inaccurate, but they're chosen to be as distinguishable as possible, IIUC.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants