feat: add file size-based chunking to JsonOutput (WIP) #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 72.9%) Detailed Coverage Report |
inishchith
force-pushed
the
feat/add-file-size-based-chunking
branch
from
3ea6815 to
8987cb7
Compare
inishchith
changed the title
📦 Trivy Vulnerability Scan Results
Report Summary
Scan Result Details✅ No vulnerabilities found during the scan for |
📦 Trivy Secret Scan Results
Report Summary
Scan Result Details✅ No secrets found during the scan for |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
🛠 Docs available at: https://k.atlan.dev/application-sdk/feat/add-file-size-based-chunking |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
🛠 Full Test Coverage Report: https://k.atlan.dev/coverage/application-sdk/pr/650 |
1 similar comment
|
🛠 Full Test Coverage Report: https://k.atlan.dev/coverage/application-sdk/pr/650 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| self.buffer.append(chunk) | ||
| self.current_buffer_size += len(chunk) | ||
| self.current_buffer_size_bytes += chunk_size_bytes |
There was a problem hiding this comment.
Bug: JsonOutput Buffer Flush Fails for Oversized Initial Chunks
The JsonOutput's size-based flush condition (current_buffer_size > 0) prevents flushing when the buffer is empty, even if the first chunk's estimated size exceeds max_file_size_bytes. This results in oversized files being written, which then fail to upload via ObjectStoreOutput.push_file_to_object_store due to DAPR gRPC message size limits. The current logic does not split an oversized single chunk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
estimate_dataframe_json_size()function to estimate JSON size of DataFrames - Add byte-level buffer tracking alongside existing record count trackingAdditional context (e.g. screenshots, logs, links)
Checklist
Copyleft License Compliance