Skip to content

Conversation

samypr100
Copy link
Collaborator

@samypr100 samypr100 commented Aug 4, 2025

Summary

  1. Given the upcoming 1.89 update, this bumps uv-trampoline to "~1.87" (closest nightly) from "~1.86" (closest nightly).
  2. Adds additional CI check for arm builds now that runners are available.

I wasn't sure the MSRV policy applies to uv-trampoline, so I didn't go for higher than ~1.87 nightly.
This PR also fixes a build issue starting after 1.87 where fma and fmaf symbols were missing.
Temporarily dded #[allow(clippy::ptr_eq)] to close_handles as this lint should not trigger anymore in 1.88 and above.

Test Plan

Existing tests and local build process. I did not commit the built binaries for security purposes.

@samypr100 samypr100 added the windows Specific to the Windows platform label Aug 4, 2025
@samypr100 samypr100 marked this pull request as ready for review August 5, 2025 00:15
@konstin konstin enabled auto-merge (squash) August 6, 2025 12:08
@konstin konstin merged commit d233061 into astral-sh:main Aug 6, 2025
174 of 176 checks passed
Copy link

codspeed-hq bot commented Aug 6, 2025

CodSpeed Instrumentation Performance Report

Merging #15052 will degrade performances by 13.28%

Comparing samypr100:trampoline-187-update (ec7f24b) with main (91653f5)

Summary

❌ 1 regressions
✅ 2 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
resolve_warm_airflow 687.3 ms 792.6 ms -13.28%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Specific to the Windows platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants