Rust 1.73 #8007
Rust 1.73 #8007
Conversation
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
| @@ -149,7 +149,7 @@ impl Notebook { | |||
| { | |||
| let trailing_newline = reader.seek(SeekFrom::End(-1)).is_ok_and(|_| { | |||
| let mut buf = [0; 1]; | |||
| reader.read_exact(&mut buf).is_ok_and(|_| buf[0] == b'\n') | |||
| reader.read_exact(&mut buf).is_ok_and(|()| buf[0] == b'\n') | |||
There was a problem hiding this comment.
Not convinced by that clippy change tbh (the other ones are good though)
There was a problem hiding this comment.
I don't mind disabling that lint... Here's the documentation of the rule and why https://rust-lang.github.io/rust-clippy/master/index.html#/ignored_unit_patterns
I was like, meh but then it's rare and not too bad
There was a problem hiding this comment.
I'm fine with it, don't feel strongly.
CodSpeed Performance ReportMerging #8007 will improve performances by 4.99%Comparing Summary
Benchmarks breakdown
|
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
|
I'd been holding off on this as Homebrew doesn't yet support it (conda-forge does): Homebrew/homebrew-core#149754 |
This should be fine as far as I understand because I only bumped our toolchain version but not the minimal required Rust version (Cargo.toml where we still use 1.71) |
MichaReiser
force-pushed
the
rust-1.73.0
branch
from
3c0e319 to
acc594f
Compare
|
Just tested |
|
FYI, rust 1.74.0 got shipped in the homebrew side now, Homebrew/homebrew-core#154526 |
|
Thank you @chenrui333! |
Summary
Upgrade to Rust 1.73
Test Plan
cargo test