[ruff] Treat yield before break from a terminal loop as terminal (RUF075)#25447
Merged
Merged
Conversation
|
ntBre
added
rule
ntBre
approved these changes
May 29, 2026
ntBre
left a comment
ntBre
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, thank you!
Contributor
There was a problem hiding this comment.
This is awesome! Thank you for embracing the mdtests!
Contributor
Author
There was a problem hiding this comment.
thank you so much :)
ntBre
changed the title
ruff] Treat yield before break from a terminal loop as terminal in RUF075
ntBre
changed the title
ruff] Treat yield before break from a terminal loop as terminal in RUF075ruff] Treat yield before break from a terminal loop as terminal in RUF075
ntBre
changed the title
ruff] Treat yield before break from a terminal loop as terminal in RUF075ruff] Treat yield before break from a terminal loop as terminal (RUF075)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #25378.
Extends the yield-before-return terminal check to also cover yield-before-break, but only when the enclosing loop is itself in a terminal position. break exits the innermost loop, so a yield right before it has no cleanup code after it in that case.
Test Plan
mdtest passes for fallible-context-manager.md across the new and existing cases