[pylint] Standardize diagnostic message (PLR0914, PLR0917)#24996
Merged
Conversation
…pylint rules `PLR0914` and `PLR0917` used `/` as the delimiter between the current and maximum values in their diagnostic messages (e.g. `(16/15)`), while all other comparable pylint rules (`PLR0904`, `PLR0911`, `PLR0912`, `PLR0913`, `PLR0915`, `PLR0916`, `PLR1702`) use ` > ` (e.g. `(16 > 15)`). Standardize these two rules to match. Closes astral-sh#24985
brian-c11
force-pushed
the
fix/plr0914-plr0917-delimiter
branch
from
fec2a6a to
2ee4a9e
Compare
ntBre
added
rule
ntBre
changed the title
> to match other pylint rulespylint] Standardize diagnostic message (PLR0914, PLR0917)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PLR0914(too-many-locals) andPLR0917(too-many-positional-arguments) used/as the delimiter between the current and maximum values in their diagnostic messages, while all other comparable pylint rules use>.Before:
After:
This matches the format used by
PLR0904,PLR0911,PLR0912,PLR0913,PLR0915,PLR0916, andPLR1702.Closes #24985
Test plan
PLR0914andPLR0917too_many_locals,max_positional_args,rule_toomanypositionalarguments_...)