Skip to content

[pyupgrade] Fix false positive for TypeVar default before 3.12 (UP046) #23540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntBre merged 2 commits into from
Feb 24, 2026
Merged

[pyupgrade] Fix false positive for TypeVar default before 3.12 (UP046) #23540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dbc947
add failing test case
ntBre Feb 24, 2026
65629c9
only check positional arguments
ntBre Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/ruff_linter/resources/test/fixtures/pyupgrade/UP046_2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,7 @@

class DefaultTypeVar(Generic[T]):
var: T


class KeywordArguments(Generic[T], metaclass=type):
var: T
2 changes: 1 addition & 1 deletion crates/ruff_linter/src/rules/pyupgrade/rules/pep695/non_pep695_generic_class.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ pub(crate) fn non_pep695_generic_class(checker: &Checker, class_def: &StmtClassD
//
// because `find_generic` also finds the *first* Generic argument, this has the additional
// benefit of bailing out with a diagnostic if multiple Generic arguments are present
if generic_idx != arguments.len() - 1 {
if generic_idx != arguments.args.len() - 1 {
return;
}

Expand Down