[ty] Add subdiagnostic hint if the user wrote X = Any rather than X: Any
#21777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
requested review from
carljm,
dcreager and
sharkdp
as code owners
AlexWaygood
added
ty
Diagnostic diff on typing conformance testsChanges were detected when running ty on typing conformance tests--- old-output.txt 2025-12-03 17:36:22.183723401 +0000
+++ new-output.txt 2025-12-03 17:36:25.927749245 +0000
@@ -915,7 +915,7 @@
specialtypes_type.py:120:5: error[unresolved-attribute] Object of type `type` has no attribute `unknown`
specialtypes_type.py:137:5: error[type-assertion-failure] Type `type[Any]` does not match asserted type `type`
specialtypes_type.py:139:5: error[type-assertion-failure] Type `type[Any]` does not match asserted type `type`
-specialtypes_type.py:143:1: error[unresolved-attribute] Object of type `typing.Type` has no attribute `unknown`
+specialtypes_type.py:143:1: error[unresolved-attribute] Special form `typing.Type` has no attribute `unknown`
specialtypes_type.py:145:1: error[unresolved-attribute] Class `type` has no attribute `unknown`
specialtypes_type.py:169:21: error[invalid-assignment] Object of type `type` is not assignable to `type[int]`
specialtypes_type.py:175:16: error[invalid-return-type] Return type does not match returned value: expected `type[T@ClassA]`, found `type`
|
|
Member
Author
|
The ecosystem impact seems fine. Those |
sharkdp
approved these changes
Dec 3, 2025
Comment on lines
+9115
to
+9121
| fn is_dotted_name(attribute: &ast::Expr) -> bool { | ||
| match attribute { | ||
| ast::Expr::Name(_) => true, | ||
| ast::Expr::Attribute(ast::ExprAttribute { value, .. }) => is_dotted_name(value), | ||
| _ => false, | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Is it worth reusing this (also used in is_if_type_checking)? Fine if not, it's short enough.
Member
Author
There was a problem hiding this comment.
I think I'll pass -- it's a tiny routine, and semantic_index/builder.rs feels like a long way away from this code.
Comment on lines
+9232
to
+9236
| maybe_n = if attr_name.starts_with(['a', 'e', 'i', 'o', 'u']) { | ||
| "n" | ||
| } else { | ||
| "" | ||
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes astral-sh/ty#1744