Skip to content

Conversation

@ericmarkmartin
Copy link
Contributor

Summary

Add docstrings to some ty_extensions functions that test predicates on types.

Additionally update some keyword argument names in these functions to clarify which direction the relevant relations are being tested.

Test Plan

Manually tested with a local ty language server that the new docstrings show up.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

@AlexWaygood AlexWaygood added internal An internal refactor or improvement ty Multi-file analysis & type inference labels Oct 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

mypy_primer results

No ecosystem changes detected ✅
No memory usage changes detected ✅

@ericmarkmartin ericmarkmartin marked this pull request as ready for review October 22, 2025 22:56
Copy link
Contributor

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@sharkdp sharkdp changed the title [ty] Add docstrings to some ty_extensions functions [ty] Add docstrings for ty_extensions functions Oct 23, 2025
@MichaReiser MichaReiser merged commit c3631c7 into astral-sh:main Oct 23, 2025
40 checks passed
@ericmarkmartin ericmarkmartin deleted the ty-extensions-docstrings branch November 12, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants