[syntax-errors] Alternative match patterns bind different names

[11happy]

Summary

This PR implements semantic syntax error where alternative patterns bind different names

Test Plan

I have written inline tests as directed in #17412

[11happy]

test /ruff/crates/ty_python_semantic/resources/mdtest/import/star.md is failing as now two syntax errors are emitted at same line line 295 & 366, Can we add multiple syntax errors on the same line ?

Thank you

[ntBre]

Thank you! This looks good overall. I just had a couple of suggestions about test cases and a bit of a simplification/possible performance improvement.

[ntBre]

test /ruff/crates/ty_python_semantic/resources/mdtest/import/star.md is failing as now two syntax errors are emitted at same line line 295 & 366, Can we add multiple syntax errors on the same line ?

Yes, I think you can stack the comments, although you may need to move the existing one to the previous line like this:

    # error: [invalid-syntax] "name capture `E` makes remaining patterns unreachable"
    # error: [invalid-syntax] "your error here"
    case E | F:  
        ...

[11happy]

test /ruff/crates/ty_python_semantic/resources/mdtest/import/star.md is failing as now two syntax errors are emitted at same line line 295 & 366, Can we add multiple syntax errors on the same line ?

Yes, I think you can stack the comments, although you may need to move the existing one to the previous line like this:

    # error: [invalid-syntax] "name capture `E` makes remaining patterns unreachable"
    # error: [invalid-syntax] "your error here"
    case E | F:  
        ...

Sure, have added accordingly.
Thank you : )

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

[11happy]

rebased : )

[ntBre]

Thank you!

I pushed two small commits, one using the full match pattern's range like CPython does. I think the narrower range could be helpful in the future, but the whole thing seems okay for now. And one renaming the error to DifferentMatchPatternBindings. I still don't totally love the name, but it's not user-facing, so we can always iterate on it if needed.

[henryiii]

This change seems to now cause a SyntaxError on the following valid code that doesn't use different names:

invalid-syntax: alternative patterns bind different names
   --> src/sp_repo_review/checks/ruff.py:127:17
    |
125 |           match ruff:
126 |               case (
127 | /                 {"lint": {"select": x} | {"extend-select": x}}
128 | |                 | {"select": x}
129 | |                 | {"extend-select": x}
    | |______________________________________^
130 |               ):
131 |                   return cls.code in x or "ALL" in x
    |

See scientific-python/cookie#663