[playground] Allow hover quick fixes to appear for overlapping diagnostics
#20527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
reviewed
Sep 23, 2025
Comment on lines
140
to
167
| const isBeforeOrEqual = ( | ||
| lineA: number, | ||
| colA: number, | ||
| lineB: number, | ||
| colB: number, | ||
| ) => lineA < lineB || (lineA === lineB && colA <= colB); | ||
|
|
||
| const isAfterOrEqual = ( | ||
| lineA: number, | ||
| colA: number, | ||
| lineB: number, | ||
| colB: number, | ||
| ) => lineA > lineB || (lineA === lineB && colA >= colB); | ||
|
|
||
| // Ranges [diagStart, diagEnd] and [rangeStart, rangeEnd] intersect if: | ||
| // diagStart <= rangeEnd AND diagEnd >= rangeStart | ||
| const diagStartsBeforeOrAtRangeEnd = isBeforeOrEqual( | ||
| diagStartLine, | ||
| diagStartCol, | ||
| rangeEndLine, | ||
| rangeEndCol, | ||
| ); | ||
| const diagEndsAfterOrAtRangeStart = isAfterOrEqual( | ||
| diagEndLine, | ||
| diagEndCol, | ||
| rangeStartLine, | ||
| rangeStartCol, | ||
| ); |
There was a problem hiding this comment.
Can we use range.containsRange(other_range) here instead (or the other way round or any other range method)
MichaReiser
reviewed
Sep 23, 2025
|
I did some digging and found |
MichaReiser
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19655
codeon markers withdiagnostic.code ?? undefinedto satisfy Monaco’sIMarkerDatatype and ensure the rule code shows up without type errors.