Track t-strings and f-strings for token-based rules and suppression comments#20357
Merged
Conversation
Contributor
|
ntBre
approved these changes
Sep 12, 2025
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Nice, thank you! This looks good to me, I just had a few questions for my understanding and a couple of very minor nits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our token-based rules and
noqaextraction used anIndexerthat kept track of f-string ranges but not t-strings. We've updated theIndexerand downstream uses thereof to handle both f-strings and t-strings.Most of the diff is renaming and adding tests.
Note that much of the "new" logic gets to be naive because the lexer has already ensured that f and t-string "starts" are paired with their respective "ends", even amidst nesting and so on.
Finally: one could imagine wanting to know if a given interpolated string range corresponds to an f-string or a t-string, but I didn't find a place where we actually needed this.
Closes #20310