[refurb] Mark single-item-membership-test fix as always unsafe (FURB171)#20279
Merged
Conversation
TaKO8Ki
commented
Sep 6, 2025
| Applicability::Safe | ||
| }; | ||
| // All supported cases can change runtime behavior; mark as unsafe. | ||
| let applicability = Applicability::Unsafe; |
Contributor
Author
There was a problem hiding this comment.
Previously, fixes were marked unsafe only for string literals and when comments intersected the edit range, but single‑item list/tuple/set/frozenset cases can also
change behavior (e.g., NaN identity differences and non‑boolean eq), so we now mark all FURB171 fixes as unsafe.
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| FURB171 | 64 | 0 | 0 | 0 | 64 |
ntBre
reviewed
Sep 11, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks, this looks good! I just had a couple of minor suggestions. I agree with marking the fix as always unsafe instead of trying to look for the few special safe cases mentioned in the issue. I think that could get pretty complicated.
ntBre
added
fixes
ntBre
changed the title
refurb] Mark single-item-membership-test fixes as always unsaferefurb] Mark single-item-membership-test fix as always unsafe (FURB171)
ntBre
approved these changes
Sep 18, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thank you! Just a couple of small docs nits that I'll apply and then merge this :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20255
Mark single-item-membership-test fixes as always unsafe
Applicability::Unsafefor FURB171 fixesTest Plan
I have added new test cases to
crates/ruff_linter/resources/test/fixtures/refurb/FURB171_0.pyandcrates/ruff_linter/resources/test/fixtures/refurb/FURB171_1.py.