[`flake8-type-checking`, `pyupgrade`, `ruff`] Add `from future import annotations` when it would allow new fixes (`TC001`, `TC002`, `TC003`, `UP037`, `RUF013`) #19100

ntBre · 2025-07-02T19:38:53Z

Summary

This is a second attempt at addressing #18502 instead of reusing FA100 (#18919).

This PR:

adds a new lint.allow-importing-future-annotations option
uses the option to add a __future__ import when it would trigger TC001, TC002, or TC003
uses the option to add an import when it would allow unquoting more annotations in quoted-annotation (UP037)
uses the option to allow the | union syntax before 3.10 in implicit-optional (RUF013)

I started adding a fix for runtime-string-union (TC010) too, as mentioned in my previous comment, but some of the existing tests already imported from __future__ import annotations, so I think we intentionally flag these cases for the user to inspect. Adding the import is a fix but probably not the best one.

Test Plan

Existing TC tests, new copies of them with the option enabled, and new tests based on ideas in #18919 (comment) and the following thread. For UP037 and RUF013, the new tests are also copies of the existing tests, with the new option enabled. The easiest way to review them is probably by their diffs from the existing snapshots:

UP037

UP037_0.py and UP037_2.pyi have no diffs. The diff for UP037_1.py is below. It correctly unquotes an annotation in module scope that would otherwise be invalid.

UP037_1.py

3d2
< snapshot_kind: text
23c22,42
< 12 12 |
---
> 12 12 |
>
> UP037_1.py:14:4: UP037 [*] Remove quotes from type annotation
>    |
> 13 | # OK
> 14 | X: "Tuple[int, int]" = (0, 0)
>    |    ^^^^^^^^^^^^^^^^^ UP037
>    |
>    = help: Remove quotes
>
> ℹ Unsafe fix
>    1  |+from __future__ import annotations
> 1  2  | from typing import TYPE_CHECKING
> 2  3  |
> 3  4  | if TYPE_CHECKING:
> --------------------------------------------------------------------------------
> 11 12 |
> 12 13 |
> 13 14 | # OK
> 14    |-X: "Tuple[int, int]" = (0, 0)
>    15 |+X: Tuple[int, int] = (0, 0)

RUF013

The diffs here are mostly just the imports because the original snaps were on 3.13. So we're getting the same fixes now on 3.9.

RUF013_0.py

3d2
< snapshot_kind: text
14,16c13,20
< 17 17 |     pass
< 18 18 | 
< 19 19 | 
---
>    1  |+from __future__ import annotations
> 1  2  | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2  3  | 
> 3  4  | 
> --------------------------------------------------------------------------------
> 17 18 |     pass
> 18 19 | 
> 19 20 | 
18,21c22,25
<    20 |+def f(arg: int | None = None):  # RUF013
< 21 21 |     pass
< 22 22 | 
< 23 23 | 
---
>    21 |+def f(arg: int | None = None):  # RUF013
> 21 22 |     pass
> 22 23 | 
> 23 24 | 
32,34c36,43
< 21 21 |     pass
< 22 22 | 
< 23 23 | 
---
>    1  |+from __future__ import annotations
> 1  2  | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2  3  | 
> 3  4  | 
> --------------------------------------------------------------------------------
> 21 22 |     pass
> 22 23 | 
> 23 24 | 
36,39c45,48
<    24 |+def f(arg: str | None = None):  # RUF013
< 25 25 |     pass
< 26 26 | 
< 27 27 | 
---
>    25 |+def f(arg: str | None = None):  # RUF013
> 25 26 |     pass
> 26 27 | 
> 27 28 | 
50,52c59,66
< 25 25 |     pass
< 26 26 | 
< 27 27 | 
---
>    1  |+from __future__ import annotations
> 1  2  | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2  3  | 
> 3  4  | 
> --------------------------------------------------------------------------------
> 25 26 |     pass
> 26 27 | 
> 27 28 | 
54,57c68,71
<    28 |+def f(arg: Tuple[str] | None = None):  # RUF013
< 29 29 |     pass
< 30 30 | 
< 31 31 | 
---
>    29 |+def f(arg: Tuple[str] | None = None):  # RUF013
> 29 30 |     pass
> 30 31 | 
> 31 32 | 
68,70c82,89
< 55 55 |     pass
< 56 56 | 
< 57 57 | 
---
>    1  |+from __future__ import annotations
> 1  2  | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2  3  | 
> 3  4  | 
> --------------------------------------------------------------------------------
> 55 56 |     pass
> 56 57 | 
> 57 58 | 
72,75c91,94
<    58 |+def f(arg: Union | None = None):  # RUF013
< 59 59 |     pass
< 60 60 | 
< 61 61 | 
---
>    59 |+def f(arg: Union | None = None):  # RUF013
> 59 60 |     pass
> 60 61 | 
> 61 62 | 
86,88c105,112
< 59 59 |     pass
< 60 60 | 
< 61 61 | 
---
>    1  |+from __future__ import annotations
> 1  2  | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2  3  | 
> 3  4  | 
> --------------------------------------------------------------------------------
> 59 60 |     pass
> 60 61 | 
> 61 62 | 
90,93c114,117
<    62 |+def f(arg: Union[int] | None = None):  # RUF013
< 63 63 |     pass
< 64 64 | 
< 65 65 | 
---
>    63 |+def f(arg: Union[int] | None = None):  # RUF013
> 63 64 |     pass
> 64 65 | 
> 65 66 | 
104,106c128,135
< 63 63 |     pass
< 64 64 | 
< 65 65 | 
---
>    1  |+from __future__ import annotations
> 1  2  | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2  3  | 
> 3  4  | 
> --------------------------------------------------------------------------------
> 63 64 |     pass
> 64 65 | 
> 65 66 | 
108,111c137,140
<    66 |+def f(arg: Union[int, str] | None = None):  # RUF013
< 67 67 |     pass
< 68 68 | 
< 69 69 | 
---
>    67 |+def f(arg: Union[int, str] | None = None):  # RUF013
> 67 68 |     pass
> 68 69 | 
> 69 70 | 
122,124c151,158
< 82 82 |     pass
< 83 83 | 
< 84 84 | 
---
>    1  |+from __future__ import annotations
> 1  2  | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2  3  | 
> 3  4  | 
> --------------------------------------------------------------------------------
> 82 83 |     pass
> 83 84 | 
> 84 85 | 
126,129c160,163
<    85 |+def f(arg: int | float | None = None):  # RUF013
< 86 86 |     pass
< 87 87 | 
< 88 88 | 
---
>    86 |+def f(arg: int | float | None = None):  # RUF013
> 86 87 |     pass
> 87 88 | 
> 88 89 | 
140,142c174,181
< 86 86 |     pass
< 87 87 | 
< 88 88 | 
---
>    1  |+from __future__ import annotations
> 1  2  | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2  3  | 
> 3  4  | 
> --------------------------------------------------------------------------------
> 86 87 |     pass
> 87 88 | 
> 88 89 | 
144,147c183,186
<    89 |+def f(arg: int | float | str | bytes | None = None):  # RUF013
< 90 90 |     pass
< 91 91 | 
< 92 92 | 
---
>    90 |+def f(arg: int | float | str | bytes | None = None):  # RUF013
> 90 91 |     pass
> 91 92 | 
> 92 93 | 
158,160c197,204
< 105 105 |     pass
< 106 106 | 
< 107 107 | 
---
>     1   |+from __future__ import annotations
> 1   2   | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2   3   | 
> 3   4   | 
> --------------------------------------------------------------------------------
> 105 106 |     pass
> 106 107 | 
> 107 108 | 
162,165c206,209
<     108 |+def f(arg: Literal[1] | None = None):  # RUF013
< 109 109 |     pass
< 110 110 | 
< 111 111 | 
---
>     109 |+def f(arg: Literal[1] | None = None):  # RUF013
> 109 110 |     pass
> 110 111 | 
> 111 112 | 
176,178c220,227
< 109 109 |     pass
< 110 110 | 
< 111 111 | 
---
>     1   |+from __future__ import annotations
> 1   2   | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2   3   | 
> 3   4   | 
> --------------------------------------------------------------------------------
> 109 110 |     pass
> 110 111 | 
> 111 112 | 
180,183c229,232
<     112 |+def f(arg: Literal[1, "foo"] | None = None):  # RUF013
< 113 113 |     pass
< 114 114 | 
< 115 115 | 
---
>     113 |+def f(arg: Literal[1, "foo"] | None = None):  # RUF013
> 113 114 |     pass
> 114 115 | 
> 115 116 | 
194,196c243,250
< 128 128 |     pass
< 129 129 | 
< 130 130 | 
---
>     1   |+from __future__ import annotations
> 1   2   | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2   3   | 
> 3   4   | 
> --------------------------------------------------------------------------------
> 128 129 |     pass
> 129 130 | 
> 130 131 | 
198,201c252,255
<     131 |+def f(arg: Annotated[int | None, ...] = None):  # RUF013
< 132 132 |     pass
< 133 133 | 
< 134 134 | 
---
>     132 |+def f(arg: Annotated[int | None, ...] = None):  # RUF013
> 132 133 |     pass
> 133 134 | 
> 134 135 | 
212,214c266,273
< 132 132 |     pass
< 133 133 | 
< 134 134 | 
---
>     1   |+from __future__ import annotations
> 1   2   | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2   3   | 
> 3   4   | 
> --------------------------------------------------------------------------------
> 132 133 |     pass
> 133 134 | 
> 134 135 | 
216,219c275,278
<     135 |+def f(arg: Annotated[Annotated[int | str | None, ...], ...] = None):  # RUF013
< 136 136 |     pass
< 137 137 | 
< 138 138 | 
---
>     136 |+def f(arg: Annotated[Annotated[int | str | None, ...], ...] = None):  # RUF013
> 136 137 |     pass
> 137 138 | 
> 138 139 | 
232,234c291,298
< 148 148 | 
< 149 149 | 
< 150 150 | def f(
---
>     1   |+from __future__ import annotations
> 1   2   | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2   3   | 
> 3   4   | 
> --------------------------------------------------------------------------------
> 148 149 | 
> 149 150 | 
> 150 151 | def f(
236,239c300,303
<     151 |+    arg1: int | None = None,  # RUF013
< 152 152 |     arg2: Union[int, float] = None,  # RUF013
< 153 153 |     arg3: Literal[1, 2, 3] = None,  # RUF013
< 154 154 | ):
---
>     152 |+    arg1: int | None = None,  # RUF013
> 152 153 |     arg2: Union[int, float] = None,  # RUF013
> 153 154 |     arg3: Literal[1, 2, 3] = None,  # RUF013
> 154 155 | ):
253,255c317,324
< 149 149 | 
< 150 150 | def f(
< 151 151 |     arg1: int = None,  # RUF013
---
>     1   |+from __future__ import annotations
> 1   2   | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2   3   | 
> 3   4   | 
> --------------------------------------------------------------------------------
> 149 150 | 
> 150 151 | def f(
> 151 152 |     arg1: int = None,  # RUF013
257,260c326,329
<     152 |+    arg2: Union[int, float] | None = None,  # RUF013
< 153 153 |     arg3: Literal[1, 2, 3] = None,  # RUF013
< 154 154 | ):
< 155 155 |     pass
---
>     153 |+    arg2: Union[int, float] | None = None,  # RUF013
> 153 154 |     arg3: Literal[1, 2, 3] = None,  # RUF013
> 154 155 | ):
> 155 156 |     pass
274,276c343,350
< 150 150 | def f(
< 151 151 |     arg1: int = None,  # RUF013
< 152 152 |     arg2: Union[int, float] = None,  # RUF013
---
>     1   |+from __future__ import annotations
> 1   2   | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2   3   | 
> 3   4   | 
> --------------------------------------------------------------------------------
> 150 151 | def f(
> 151 152 |     arg1: int = None,  # RUF013
> 152 153 |     arg2: Union[int, float] = None,  # RUF013
278,281c352,355
<     153 |+    arg3: Literal[1, 2, 3] | None = None,  # RUF013
< 154 154 | ):
< 155 155 |     pass
< 156 156 | 
---
>     154 |+    arg3: Literal[1, 2, 3] | None = None,  # RUF013
> 154 155 | ):
> 155 156 |     pass
> 156 157 | 
292,294c366,373
< 178 178 |     pass
< 179 179 | 
< 180 180 | 
---
>     1   |+from __future__ import annotations
> 1   2   | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2   3   | 
> 3   4   | 
> --------------------------------------------------------------------------------
> 178 179 |     pass
> 179 180 | 
> 180 181 | 
296,299c375,378
<     181 |+def f(arg: Union[Annotated[int, ...], Union[str, bytes]] | None = None):  # RUF013
< 182 182 |     pass
< 183 183 | 
< 184 184 | 
---
>     182 |+def f(arg: Union[Annotated[int, ...], Union[str, bytes]] | None = None):  # RUF013
> 182 183 |     pass
> 183 184 | 
> 184 185 | 
307c386
<     = help: Convert to `T | None`
---
>     = help: Convert to `Optional[T]`
314c393
<     188 |+def f(arg: "int | None" = None):  # RUF013
---
>     188 |+def f(arg: "Optional[int]" = None):  # RUF013
325c404
<     = help: Convert to `T | None`
---
>     = help: Convert to `Optional[T]`
332c411
<     192 |+def f(arg: "str | None" = None):  # RUF013
---
>     192 |+def f(arg: "Optional[str]" = None):  # RUF013
343c422
<     = help: Convert to `T | None`
---
>     = help: Convert to `Optional[T]`
354,356c433,440
< 201 201 |     pass
< 202 202 | 
< 203 203 | 
---
>     1   |+from __future__ import annotations
> 1   2   | from typing import Annotated, Any, Literal, Optional, Tuple, Union, Hashable
> 2   3   | 
> 3   4   | 
> --------------------------------------------------------------------------------
> 201 202 |     pass
> 202 203 | 
> 203 204 | 
358,361c442,445
<     204 |+def f(arg: Union["int", "str"] | None = None):  # RUF013
< 205 205 |     pass
< 206 206 | 
< 207 207 |
---
>     205 |+def f(arg: Union["int", "str"] | None = None):  # RUF013
> 205 206 |     pass
> 206 207 | 
> 207 208 |

RUF013_1.py

3d2
< snapshot_kind: text
15,16c14,16
< 2 2 |
< 3 3 |
---
>   2 |+from __future__ import annotations
> 2 3 |
> 3 4 |
18,19c18,19
<   4 |+def f(arg: int | None = None):  # RUF013
< 5 5 |     pass
---
>   5 |+def f(arg: int | None = None):  # RUF013
> 5 6 |     pass

RUF013_3.py

3d2
< snapshot_kind: text
14,16c13,16
< 1 1 | import typing
< 2 2 | 
< 3 3 | 
---
>   1 |+from __future__ import annotations
> 1 2 | import typing
> 2 3 | 
> 3 4 | 
18,21c18,21
<   4 |+def f(arg: typing.List[str] | None = None):  # RUF013
< 5 5 |     pass
< 6 6 | 
< 7 7 | 
---
>   5 |+def f(arg: typing.List[str] | None = None):  # RUF013
> 5 6 |     pass
> 6 7 | 
> 7 8 | 
32,34c32,39
< 19 19 |     pass
< 20 20 | 
< 21 21 | 
---
>    1  |+from __future__ import annotations
> 1  2  | import typing
> 2  3  | 
> 3  4  | 
> --------------------------------------------------------------------------------
> 19 20 |     pass
> 20 21 | 
> 21 22 | 
36,39c41,44
<    22 |+def f(arg: typing.Union[int, str] | None = None):  # RUF013
< 23 23 |     pass
< 24 24 | 
< 25 25 | 
---
>    23 |+def f(arg: typing.Union[int, str] | None = None):  # RUF013
> 23 24 |     pass
> 24 25 | 
> 25 26 | 
50,52c55,62
< 26 26 | # Literal
< 27 27 | 
< 28 28 | 
---
>    1  |+from __future__ import annotations
> 1  2  | import typing
> 2  3  | 
> 3  4  | 
> --------------------------------------------------------------------------------
> 26 27 | # Literal
> 27 28 | 
> 28 29 | 
54,55c64,65
<    29 |+def f(arg: typing.Literal[1, "foo", True] | None = None):  # RUF013
< 30 30 |     pass
---
>    30 |+def f(arg: typing.Literal[1, "foo", True] | None = None):  # RUF013
> 30 31 |     pass

RUF013_4.py

3d2
< snapshot_kind: text
13,15c12,20
< 12 12 | def multiple_1(arg1: Optional, arg2: Optional = None): ...
< 13 13 |
< 14 14 |
---
> 1  1  | # https://github.com/astral-sh/ruff/issues/13833
>    2  |+from __future__ import annotations
> 2  3  |
> 3  4  | from typing import Optional
> 4  5  |
> --------------------------------------------------------------------------------
> 12 13 | def multiple_1(arg1: Optional, arg2: Optional = None): ...
> 13 14 |
> 14 15 |
17,20c22,25
<    15 |+def multiple_2(arg1: Optional, arg2: Optional = None, arg3: int | None = None): ...
< 16 16 |
< 17 17 |
< 18 18 | def return_type(arg: Optional = None) -> Optional: ...
---
>    16 |+def multiple_2(arg1: Optional, arg2: Optional = None, arg3: int | None = None): ...
> 16 17 |
> 17 18 |
> 18 19 | def return_type(arg: Optional = None) -> Optional: ...

Future work

This PR does not touch UP006, UP007, or UP045, which are currently coupled to FA100. If this new approach turns out well, we may eventually want to deprecate FA100 and add a __future__ import in those rules' fixes too.

github-actions · 2025-07-02T19:47:56Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Daverball

Looks pretty good to me, but I think we should test the interaction with quote-annotations more carefully.

crates/ruff_linter/src/rules/flake8_type_checking/mod.rs

crates/ruff_linter/src/rules/flake8_type_checking/rules/typing_only_runtime_import.rs

MichaReiser · 2025-07-08T09:20:42Z

Do we need to add the same check to other rules as well (UP?).

ntBre · 2025-07-09T22:09:22Z

Thanks @Daverball, your suspicions were true. I wasn't handling the quoting setting properly. I resurrected some of the ideas from #18919 but with four values, as you suggested there (Yes, No, Future, and Quote instead of Yes/No/Maybe).

I think this looks a lot nicer (modulo the somewhat awkward names I picked) and handles both settings being enabled, as the updated tests show.

I'll extend this to the UP rules tomorrow, but hopefully this is a solid draft of the TC rules.

AlexWaygood

(Micha asked me to take a quick look, but I haven't done an exhaustive review. It all basically LGTM!)

crates/ruff_linter/src/importer/mod.rs

crates/ruff_linter/src/rules/flake8_type_checking/helpers.rs

Co-authored-by: Alex Waygood <[email protected]>

it's not clear from the call site that we don't need to `continue` to avoid extra work if the setting is disabled, so mention it here

ntBre · 2025-07-15T15:28:17Z

I started adding a fix for runtime-string-union (TC010) too, as mentioned in my previous comment, but some of the existing tests already imported from __future__ import annotations, so I think we intentionally flag these cases for the user to inspect. Adding the import is a fix but probably not the best one.

Hmm, I'm not sure I'm totally convinced by this reasoning. I think if you're happy with from __future__ import annotations being added in some modules, you'll probably want it to be imported in most modules where it's useful. It results in a lot less visual clutter than having quoted annotations everywhere.

That said, I'm fine deferring TC010 for now!

Ah, I see what you mean. My draft fix added the import but didn't unquote the annotation, which is why I thought it didn't make much sense. If we add the import and then unquote the annotation, this would be a nice fix.

I added this and the other rules we mentioned to #19359. Let me know if I missed any!

enable PreviewMode in the new tests

MichaReiser · 2025-07-15T16:27:13Z

I'll do another review tomorrow. Could you rebase the PR before then?

ntBre · 2025-07-15T16:28:24Z

Yep, I was merging main and getting ready to push right now!

MichaReiser

This is great. Thank you for pushing this forward

MichaReiser · 2025-07-16T07:13:27Z

crates/ruff_linter/src/rules/flake8_type_checking/helpers.rs

-                || (settings.quote_annotations && reference.in_runtime_evaluated_annotation())))
+use crate::settings::LinterSettings;
+
+/// Represents the kind of an existing or potential typing-only annotation.


Let's add a comment explaining that the variants need to be ordered by their precedence. It's sort of important

MichaReiser · 2025-07-16T07:16:37Z

crates/ruff_workspace/src/options.rs

+    ///
+    /// For example, `TC001`, `TC002`, and `TC003` can move more imports into `TYPE_CHECKING` blocks
+    /// if `__future__` annotations are enabled.
+    #[option(


I think we should mention that this option is preview only for now

update the `combine` docs with the new names

ntBre added rule Implementing or modifying a lint rule configuration Related to settings and configuration fixes Related to suggested fixes for violations labels Jul 2, 2025

ntBre mentioned this pull request Jul 3, 2025

Add autofix that adds from __future__ import annotations only when it would be useful #18502

Open

Daverball reviewed Jul 3, 2025

View reviewed changes

crates/ruff_linter/src/rules/flake8_type_checking/mod.rs Outdated Show resolved Hide resolved

MichaReiser reviewed Jul 8, 2025

View reviewed changes

crates/ruff_linter/src/rules/flake8_type_checking/rules/typing_only_runtime_import.rs Outdated Show resolved Hide resolved

MichaReiser reviewed Jul 8, 2025

View reviewed changes

crates/ruff_linter/src/rules/flake8_type_checking/rules/typing_only_runtime_import.rs Outdated Show resolved Hide resolved

ntBre added 17 commits July 14, 2025 08:11

add lint.allow-importing-future-annotations option

2c21a86

add tests with lint.allow-importing-future-annotations = true

7e1e09c

add tests that will only trigger with a __future__ import

b7b073b

passing new test but failing old ones

9342614

pass TC001 and TC003

a64b382

pass TC002

9629214

add a test when __future__ is already present

31b03ba

avoid quotes when __future__ import is present

ac26b30

add more test cases

5b5208f

combine add_future_import branches

be38274

convert to guarded continues, move add_future_import up

76aa45d

try 4-variant TypingReference

5b02606

enable quoting to ensure future imports take precedence

53b7d56

replace is_typing_reference completely

9e5d924

factor out add_future_import helper

c879b82

add future imports for up037

f510253

add future imports for ruf013

44ae933

ntBre force-pushed the brent/future-annotations-2 branch from aa2332c to 44ae933 Compare July 14, 2025 13:29

rename tests to avoid path-too-long on Windows

2a6bd8c

ntBre force-pushed the brent/future-annotations-2 branch from 428cc97 to 2a6bd8c Compare July 14, 2025 13:59

AlexWaygood reviewed Jul 15, 2025

View reviewed changes

crates/ruff_linter/src/importer/mod.rs Outdated Show resolved Hide resolved

crates/ruff_linter/src/rules/flake8_type_checking/helpers.rs Outdated Show resolved Hide resolved

crates/ruff_linter/src/rules/flake8_type_checking/helpers.rs Outdated Show resolved Hide resolved

ntBre and others added 6 commits July 15, 2025 10:00

derive Debug

0748c11

Co-authored-by: Alex Waygood <[email protected]>

TypingReference::Yes -> TypingOnly, No -> Runtime

8c252a8

reorder TypingReference variants, move docs, derive Ord

268db77

compute sequence of references in from_references

8b52cf4

add_future_import, in_typing_only_annotation into quoted_annotation

d8abdb5

add comment about setting add_future_import

c3e95dd

it's not clear from the call site that we don't need to `continue` to avoid extra work if the setting is disabled, so mention it here

ntBre mentioned this pull request Jul 15, 2025

Add from __future__ import annotations in more rules #19359

Open

5 tasks

ntBre added 8 commits July 15, 2025 11:29

add comment about TextSize::default

28a82de

store needs_future_import on each ImportBinding

bf19aca

localize add_future_import check for implicit_optional

bc91ee0

mention new option and preview behavior for TC rules

40424f5

mention new option and preview behavior for UP037

0992a43

mention new option and preview behavior for RUF013

4c53fad

Add LinterSettings::allow_importing_future_annotations for preview

262ac4f

enable PreviewMode in the new tests

allow-importing-future-annotations -> future-annotations

eba43a1

MichaReiser added the preview Related to preview mode features label Jul 15, 2025

Merge branch 'main' into brent/future-annotations-2

d81ba58

ntBre added 2 commits July 15, 2025 14:28

use Importer::add_future_import for existing calls

fd9593b

add warning for conflicting future-annotations and preview settings

18c0aca

MichaReiser approved these changes Jul 16, 2025

View reviewed changes

ntBre added 2 commits July 16, 2025 08:34

add a note about the variant ordering and precedence

89304c4

update the `combine` docs with the new names

add preview note

de53e2b

ntBre changed the title ~~[flake8-type-checking] Add from __future__ import annotations to allow a fix~~ [flake8-type-checking, pyupgrade, ruff] Add from __future__ import annotations when it would allow new fixes (TC001, TC002, TC003, UP037, RUF013) Jul 16, 2025

ntBre merged commit 893f572 into main Jul 16, 2025
35 checks passed

ntBre deleted the brent/future-annotations-2 branch July 16, 2025 12:50

BrewTestBot mentioned this pull request Jul 17, 2025

ruff 0.12.4 Homebrew/homebrew-core#230452

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[`flake8-type-checking`, `pyupgrade`, `ruff`] Add `from future import annotations` when it would allow new fixes (`TC001`, `TC002`, `TC003`, `UP037`, `RUF013`) #19100

[`flake8-type-checking`, `pyupgrade`, `ruff`] Add `from future import annotations` when it would allow new fixes (`TC001`, `TC002`, `TC003`, `UP037`, `RUF013`) #19100

Uh oh!

ntBre commented Jul 2, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 2, 2025 •

edited

Loading

Uh oh!

Daverball left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MichaReiser commented Jul 8, 2025

Uh oh!

ntBre commented Jul 9, 2025

Uh oh!

AlexWaygood left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ntBre commented Jul 15, 2025

Uh oh!

MichaReiser commented Jul 15, 2025

Uh oh!

ntBre commented Jul 15, 2025

Uh oh!

MichaReiser left a comment

Uh oh!

MichaReiser Jul 16, 2025

Uh oh!

MichaReiser Jul 16, 2025

Uh oh!

Uh oh!

Uh oh!

[flake8-type-checking, pyupgrade, ruff] Add from __future__ import annotations when it would allow new fixes (TC001, TC002, TC003, UP037, RUF013) #19100

[flake8-type-checking, pyupgrade, ruff] Add from __future__ import annotations when it would allow new fixes (TC001, TC002, TC003, UP037, RUF013) #19100

Uh oh!

Conversation

ntBre commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

UP037

RUF013

Future work

Uh oh!

github-actions bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

Daverball left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MichaReiser commented Jul 8, 2025

Uh oh!

ntBre commented Jul 9, 2025

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ntBre commented Jul 15, 2025

Uh oh!

MichaReiser commented Jul 15, 2025

Uh oh!

ntBre commented Jul 15, 2025

Uh oh!

MichaReiser left a comment

Choose a reason for hiding this comment

Uh oh!

MichaReiser Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

MichaReiser Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

[`flake8-type-checking`, `pyupgrade`, `ruff`] Add `from future import annotations` when it would allow new fixes (`TC001`, `TC002`, `TC003`, `UP037`, `RUF013`) #19100

[`flake8-type-checking`, `pyupgrade`, `ruff`] Add `from future import annotations` when it would allow new fixes (`TC001`, `TC002`, `TC003`, `UP037`, `RUF013`) #19100

ntBre commented Jul 2, 2025 •

edited

Loading

github-actions bot commented Jul 2, 2025 •

edited

Loading

`ruff-ecosystem` results