[flake8-pyi
] Make example error out-of-the-box (PYI059
)
#19080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #18972
This PR makes generic-not-last-base-class (PYI059)'s example error out-of-the-box
Warning
This PR has more extensive and possibly wrong changes than my usual "Make example error out-of-the-box" PRs
I made fairly lengthy modifications so that the example is valid code (adding the
collections.abc
imports andTypeVar
s), but allPYI059
actually needs to trigger is afrom typing import Generic
. I'm not sure if this is right choice, since I'm uncertain if the examples being working code is favored vs verbosity.I also changed the
Tuple
totuple
since in modern python that would require importing the deprecated alias, but it's also not nessacary forPYI059
to trigger.Old example
New example
The "use instead" section was also modified similarly
Test Plan
N/A, no functionality/tests affected