[flake8-bandit
] Make S604
and S609
examples error out-of-the-box
#19049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #18972
Both in one PR since they are in the same file.
S604
This PR makes call-with-shell-equals-true (S604)'s example error out-of-the-box
Old example
New example
The old example doesn't raise
S604
because it gets overwritten by subprocess-popen-with-shell-equals-true (S602) (which is a good idea to prevent two lints saying the same thing from being raised)S609
This PR makes unix-command-wildcard-injection (S609)'s example error out-of-the-box
Old example
New example
I'm not familiar enough with
subprocess
to know whyshell=True
is required to makeS609
raise here, but it works.Test Plan
N/A, no functionality/tests affected