Skip to content

Conversation

robsdedude
Copy link
Contributor

Summary

Fixes: #19005

Test Plan

Reproducer from issue report plus some extra cases that would cause the panic were added.

@robsdedude robsdedude force-pushed the fix/19005-PERF403-panic branch from 06cc707 to 35e119b Compare June 30, 2025 07:58
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@robsdedude robsdedude marked this pull request as ready for review June 30, 2025 08:14
@ntBre ntBre added the bug Something isn't working label Jun 30, 2025
@dylwil3 dylwil3 changed the title [perflin]: Fix PERF403 panic on attribute or subscription loop variable [perflint]: Fix PERF403 panic on attribute or subscription loop variable Jun 30, 2025
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ntBre ntBre changed the title [perflint]: Fix PERF403 panic on attribute or subscription loop variable [perflint] Fix PERF403 panic on attribute or subscription loop variable Jun 30, 2025
@ntBre ntBre merged commit eb9d9c3 into astral-sh:main Jun 30, 2025
36 checks passed
@robsdedude robsdedude deleted the fix/19005-PERF403-panic branch June 30, 2025 19:02
iyakushev pushed a commit to iyakushev/ruff that referenced this pull request Jul 1, 2025
…riable (astral-sh#19042)

## Summary

Fixes: astral-sh#19005

## Test Plan

Reproducer from issue report plus some extra cases that would cause the
panic were added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Linter panic] “for-loop target binding must exist” for PERF403
2 participants