Skip to content

[flake8-bandit] Fix S412 false negative #19009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[flake8-bandit] Fix S412 false negative #19009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74c3da4
Core change
MeGaGiGaGon Jun 28, 2025
f403f11
Update test
MeGaGiGaGon Jun 28, 2025
df5d9d4
Update snapshot
MeGaGiGaGon Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/ruff_linter/resources/test/fixtures/flake8_bandit/S412.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
from twisted.web.twcgi import CGIScript # S412
import twisted.web.twcgi.CGIScript # S412
from wsgiref.handlers import CGIHandler # S412
import wsgiref.handlers.CGIHandler # S412
3 changes: 3 additions & 0 deletions crates/ruff_linter/resources/test/fixtures/flake8_bandit/S412.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
from twisted.web.twcgi import CGIScript
import twisted.web.twcgi.CGIScript
from wsgiref.handlers import CGIHandler
import wsgiref.handlers.CGIHandler
3 changes: 3 additions & 0 deletions crates/ruff_linter/src/rules/flake8_bandit/rules/suspicious_imports.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,9 @@ pub(crate) fn suspicious_imports(checker: &Checker, stmt: &Stmt) {
"xmlrpc" => {
checker.report_diagnostic_if_enabled(SuspiciousXmlrpcImport, name.range);
}
"wsgiref.handlers.CGIHandler" | "twisted.web.twcgi.CGIScript" => {
checker.report_diagnostic_if_enabled(SuspiciousHttpoxyImport, name.range);
}
"Crypto.Cipher" | "Crypto.Hash" | "Crypto.IO" | "Crypto.Protocol"
| "Crypto.PublicKey" | "Crypto.Random" | "Crypto.Signature" | "Crypto.Util" => {
checker.report_diagnostic_if_enabled(SuspiciousPycryptoImport, name.range);
Expand Down
29 changes: 28 additions & 1 deletion ...rules/flake8_bandit/snapshots/ruff_linter__rules__flake8_bandit__tests__S412_S412.py.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,36 @@
---
source: crates/ruff_linter/src/rules/flake8_bandit/mod.rs
snapshot_kind: text
---
S412.py:1:6: S412 `httpoxy` is a set of vulnerabilities that affect application code running inCGI, or CGI-like environments. The use of CGI for web applications should be avoided
|
1 | from twisted.web.twcgi import CGIScript # S412
| ^^^^^^^^^^^^^^^^^ S412
2 | import twisted.web.twcgi.CGIScript # S412
3 | from wsgiref.handlers import CGIHandler # S412
|

S412.py:2:8: S412 `httpoxy` is a set of vulnerabilities that affect application code running inCGI, or CGI-like environments. The use of CGI for web applications should be avoided
|
1 | from twisted.web.twcgi import CGIScript # S412
2 | import twisted.web.twcgi.CGIScript # S412
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ S412
3 | from wsgiref.handlers import CGIHandler # S412
4 | import wsgiref.handlers.CGIHandler # S412
|

S412.py:3:6: S412 `httpoxy` is a set of vulnerabilities that affect application code running inCGI, or CGI-like environments. The use of CGI for web applications should be avoided
|
1 | from twisted.web.twcgi import CGIScript # S412
2 | import twisted.web.twcgi.CGIScript # S412
3 | from wsgiref.handlers import CGIHandler # S412
| ^^^^^^^^^^^^^^^^ S412
4 | import wsgiref.handlers.CGIHandler # S412
|

S412.py:4:8: S412 `httpoxy` is a set of vulnerabilities that affect application code running inCGI, or CGI-like environments. The use of CGI for web applications should be avoided
|
2 | import twisted.web.twcgi.CGIScript # S412
3 | from wsgiref.handlers import CGIHandler # S412
4 | import wsgiref.handlers.CGIHandler # S412
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ S412
|
Loading