[ty] Enforce sort order of completions #18917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
requested review from
carljm,
MichaReiser,
AlexWaygood,
sharkdp and
dcreager
as code owners
|
Demo: vs-code-completion-order.mp4 |
|
I wonder if this means we can revert #18480? cc @MichaReiser |
|
I don't think we can because this and #18480 do the same at the API boundary (but they're different boundaries). We could add the rust analyzer does the same, but in a little fancier way: |
MichaReiser
added
server
MichaReiser
approved these changes
Jun 24, 2025
BurntSushi
force-pushed
the
ag/completion-vs-code-sort
branch
from
087d42d to
b9cc19d
Compare
We achieve this by setting the "sort text" field of every completion. Since we are trying to be smart about the order, we want the client to respect our order. Prior to this change, VS Code was re-sorting completions in lexicographic order. This in turn resulted in dunder attributes appearing before "normal" attributes.
BurntSushi
force-pushed
the
ag/completion-vs-code-sort
branch
from
b9cc19d to
b96a890
Compare
|
you probably want reviews from Micha and/or Dhruv when it comes to the bits of autocompletion that involve actually talking to the LSP client -- the only LSP I know anything about is the Liskov Substitution Principle 😛 |
dcreager
added a commit
that referenced
this pull request
Jun 24, 2025
* main: [ty] Fix false positives when subscripting an object inferred as having an `Intersection` type (#18920) [`flake8-use-pathlib`] Add autofix for `PTH202` (#18763) [ty] Add relative import completion tests [ty] Clarify what "cursor" means [ty] Add a cursor test builder [ty] Enforce sort order of completions (#18917) [formatter] Fix missing blank lines before decorated classes in .pyi files (#18888) Apply fix availability and applicability when adding to `DiagnosticGuard` and remove `NoqaCode::rule` (#18834) py-fuzzer: allow relative executable paths (#18915) [ty] Change `environment.root` to accept multiple paths (#18913) [ty] Rename `src.root` setting to `environment.root` (#18760) Use file path for detecting package root (#18914) Consider virtual path for various server actions (#18910) [ty] Introduce `UnionType::try_from_elements` and `UnionType::try_map` (#18911) [ty] Support narrowing on `isinstance()`/`issubclass()` if the second argument is a dynamic, intersection, union or typevar type (#18900) [ty] Add decorator check for implicit attribute assignments (#18587) [`ruff`] Trigger `RUF037` for empty string and byte strings (#18862) [ty] Avoid duplicate diagnostic in unpacking (#18897) [`pyupgrade`] Extend version detection to include `sys.version_info.major` (`UP036`) (#18633) [`ruff`] Frozen Dataclass default should be valid (`RUF009`) (#18735)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We achieve this by setting the "sort text" field of every completion.
Since we are trying to be smart about the order, we want the client to
respect our order.
Prior to this change, VS Code was re-sorting completions in
lexicographic order. This in turn resulted in dunder attributes
appearing before "normal" attributes.