[flake8-future-annotations] Add autofix (FA100)
#18903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary -- This PR resolves the easiest part of #18502 by adding an autofix that just adds `from __future__ import annotations` at the top of the file. We couldn't use any of the usual, existing `Importer` methods because the import must be at the very beginning of the file, so I factored out `Importer::add_import_at_start_of_file` from `Importer::add_import`. I think this is technically an unsafe fix because it changes a lot of behavior, but that's also the point of the rule, so I made it a safe fix for now. I'm happy to change it to unsafe, though. I also expected the fix only to be available sometimes, but `add_import` and `add_import_at_start_of_file` are actually infallible. Test Plan -- Existing snapshots, updated to add the fixes.
|
MichaReiser
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the easiest part of #18502 by adding an autofix that just adds
from __future__ import annotationsat the top of the file, in the same wayas FA102, which already has an identical unsafe fix.
Test Plan
Existing snapshots, updated to add the fixes.