Skip to content

Conversation

yunchipang
Copy link
Contributor

@yunchipang yunchipang commented Jun 1, 2025

parent #15584
fix was introduced in #7910

Copy link
Contributor

github-actions bot commented Jun 1, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre ntBre added the documentation Improvements or additions to documentation label Jun 1, 2025
@MichaReiser MichaReiser requested a review from dylwil3 June 2, 2025 09:15
@dylwil3
Copy link
Collaborator

dylwil3 commented Jun 2, 2025

Thanks for picking this up! Would you mind updating your PR summary as suggested in the issue? Then I'll take a look at this. Thanks again!

@yunchipang
Copy link
Contributor Author

@dylwil3 Thanks for the heads-up. I’ve added the PR link, but I’m not sure whether the unsafe change was introduced in #7910 or later in #14372 or #16685. Also, could you confirm if my unsafe example is accurate? thanks!

@yunchipang yunchipang mentioned this pull request Jun 7, 2025
71 tasks
@MichaReiser MichaReiser requested review from dylwil3 and removed request for dylwil3 June 20, 2025 06:36
Copy link
Collaborator

@dylwil3 dylwil3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think the reason you gave is correct, but we don't have to give an example. Reworded slightly and removed the example.

@dylwil3 dylwil3 enabled auto-merge (squash) June 20, 2025 15:37
@dylwil3 dylwil3 merged commit 073a71c into astral-sh:main Jun 20, 2025
34 checks passed
dcreager added a commit that referenced this pull request Jun 20, 2025
* main: (21 commits)
  [`flake8-logging`] Avoid false positive for `exc_info=True` outside `logger.exception` (`LOG014`) (#18737)
  [`flake8-pie`] Small docs fix to `PIE794` (#18829)
  [`pylint`] Ignore __init__.py files in (PLC0414) (#18400)
  Avoid generating diagnostics with per-file ignores (#18801)
  [`flake8-simplify`] Fix false negatives for shadowed bindings  (`SIM910`, `SIM911`) (#18794)
  [ty] Fix panics when pulling types for `ClassVar` or `Final` parameterized with >1 argument (#18824)
  [`pylint`] add fix safety section (`PLR1714`) (#18415)
  [Perflint] Small docs improvement to `PERF401` (#18786)
  [`pylint`] Avoid flattening nested `min`/`max` when outer call has single argument (`PLW3301`) (#16885)
  [`ruff`] Added `cls.__dict__.get('__annotations__')` check (`RUF063`) (#18233)
  [ty] Use `HashTable` in `PlaceTable` (#18819)
  docs: Correct collections-named-tuple example to use PascalCase assignment (#16884)
  [ty] ecosystem-analyzer workflow (#18719)
  [ty] Add support for `@staticmethod`s (#18809)
  unnecessary_dict_kwargs doc - a note on type checking benefits (#18666)
  [`flake8-pytest-style`] Mark autofix for `PT001` and `PT023` as unsafe if there's comments in the decorator (#18792)
  [ty] Surface matched overload diagnostic directly (#18452)
  [ty] Report when a dataclass contains more than one `KW_ONLY` field (#18731)
  [`flake8-pie`] Add fix safety section to `PIE794` (#18802)
  [`pycodestyle`] Add fix safety section to `W291` and `W293`  (#18800)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants