[airflow] Revise fix title AIR3
#18215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ntBre
added
rule
ntBre
approved these changes
May 24, 2025
crates/ruff_linter/src/rules/airflow/rules/suggested_to_update_3_0.rs
Outdated
Show resolved
Hide resolved
Separate member and module to make the fix message more accurate
Separate member and module to make the fix message more accurate
Separate member and module to make the fix message more accurate
Separate member and module to make the fix message more accurate
Lee-W
force-pushed
the
revise-AIR3-fix-title
branch
from
0b74746 to
a7473b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Originally, we use
Use {module}.{name} insteadas fix title. But it could be confusing in some cases likeairflow.providers.amazon.aws.auth_manager.avp.entitiesAvpEntities.ASSET. It's not wrong. But user won't be able to dothe following is what actually works
Test Plan
The message has been updated accordingly