[red-knot] Track reachability of scopes #17332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one is interesting -- looks like a buggy type annotation in |
Came to the exact same conclusion. I was also confused at first. Edit: this might explain it. Maybe
|
AlexWaygood
approved these changes
Apr 10, 2025
|
Love this! |
dcreager
added a commit
that referenced
this pull request
Apr 10, 2025
* main: (30 commits) [red-knot] Silence `unresolved-import` in unreachable code (#17336) red_knot_python_semantic: move TODO comment red_knot_python_semantic: rename `lint()` and `report()` ruff_db: use `Annotation::get_message` in more places red_knot_python_semantic: tweak docs on building reporter builders red_knot_python_semantic: remove the "old" secondary message type red_knot_python_semantic: replace one use of "old" secondary diagnostic messages red_knot_python_semantic: update revealed type snapshots ruff_db: tweak how the revealed type diagnostic is rendered red_knot: add explicit test for concise `reveal_type` diagnostic red_knot_python_semantic: remove `InferContext::report_diagnostic` red_knot_python_semantic: add "reporter" API Bump 0.11.5 (#17337) [red-knot] Silence `unresolved-attribute` in unreachable code (#17305) Revert "[red-knot] Type narrowing for assertions (#17149)" (#17335) [red-knot] Type narrowing for assertions (#17149) [red-knot] avoid unnecessary evaluation of visibility constraint on definitely-unbound symbol (#17326) update cargo-dist (#17325) [red-knot] Fix double hovers/inlays in playground (#17334) [red-knot] Track reachability of scopes (#17332) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Track the reachability of nested scopes within their parent scopes. We use this as an additional requirement for emitting
unresolved-referencediagnostics (and in the future,unresolved-attributeandunresolved-import). This means that we only emitunresolved-referencefor a given use of a symbol if the use itself is reachable (within its own scope), and if the scope itself is reachable. For example, no diagnostic should be emitted for the use ofxhere:There are probably more fine-grained ways of solving this problem, but they require a more sophisticated understanding of nested scopes (see astral-sh/ty#210, in particular astral-sh/ty#210). But it doesn't seem completely unreasonable to silence this specific kind of error in unreachable scopes.
Test Plan
Observed changes in reachability tests and ecosystem.