Skip to content

Add f-string formatting to the docs#15367

Merged
dhruvmanila merged 7 commits into
ruff-0.9from
dhruv/f-string-docs
Jan 9, 2025
Merged

Add f-string formatting to the docs#15367
dhruvmanila merged 7 commits into
ruff-0.9from
dhruv/f-string-docs

Conversation

@dhruvmanila

Copy link
Copy Markdown
Member

Revive #15341 as it got removed from the latest rebase in #15238.

@dhruvmanila dhruvmanila added the documentation Improvements or additions to documentation label Jan 9, 2025
@MichaReiser

Copy link
Copy Markdown
Member

Huh weird. I used --force-with-lease. Sorry for that. I assume there are no new changes that need reviewing. I suggest to just merge it.

@dhruvmanila dhruvmanila merged commit 97d95da into ruff-0.9 Jan 9, 2025
@dhruvmanila dhruvmanila deleted the dhruv/f-string-docs branch January 9, 2025 07:56
@dhruvmanila

Copy link
Copy Markdown
Member Author

24e45aa is a new commit which just adds a reference to quote-style setting in various places.

MichaReiser pushed a commit that referenced this pull request Jan 9, 2025
Revive #15341 as it got removed
from the latest rebase in #15238.

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Sorry I didn't get a chance to look properly before the release earlier

Comment thread docs/formatter.md
Comment on lines +430 to +432
f'{"""nested " """}'`
# This f-string cannot be formatted as follows when targeting Python < 3.12
f"{'''nested " '''}``

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, what's with the backticks at the end of line 430 and 432?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks! They're totally not expected

dhruvmanila added a commit that referenced this pull request Jan 10, 2025
KotlinIsland pushed a commit to KotlinIsland/basedpython that referenced this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants