Skip to content

Conversation

@MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Jun 24, 2024

Summary

This PR changes ruff <path>, ruff --explain, ruff --clean and ruff --generate-shell-completion to error but continues to print an error message. The commands were deprecated in #10169 (v0.3.0)

Part of #10171

Test Plan

I verified that:

  • The JetBrains extension uses ruff check
  • The LSP uses ruff check
  • python-lsp-ruff I think it uses ruff check

@MichaReiser MichaReiser changed the base branch from main to ruff-0.5 June 24, 2024 09:30
@MichaReiser MichaReiser added breaking Breaking API change cli Related to the command-line interface labels Jun 24, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser marked this pull request as ready for review June 24, 2024 10:07
@dhruvmanila
Copy link
Member

I'm looking at the Neovim ecosystem, already completed in conform.nvim: stevearc/conform.nvim#348

@MichaReiser
Copy link
Member Author

I changed the implementation to error instead of removing the aliases entirely.

@MichaReiser MichaReiser changed the title Remove check, --explain, --clean, --generate-shell-completion aliases` Remove check, --explain, --clean, --generate-shell-completion aliases Jun 25, 2024
@MichaReiser MichaReiser merged commit 3ad1c6c into ruff-0.5 Jun 25, 2024
@MichaReiser MichaReiser deleted the remove-CLI-aliases branch June 25, 2024 07:23
@MichaReiser MichaReiser mentioned this pull request Jun 26, 2024
MichaReiser added a commit that referenced this pull request Jun 27, 2024
MichaReiser added a commit that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking API change cli Related to the command-line interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants