`ruff:ignore` doesn't work in nested comments

[ntBre]

Our noqa parsing still considers the trailing or nested comment on the second line to be a valid suppression, but our ruff:ignore parsing does not. The first three lines suppress F401, but the last doesn't:

import math  # noqa: F401
import math  # some comment  # noqa: F401

import math  # ruff:ignore[F401]
import math  # some comment  # ruff:ignore[F401]

Playground

ty also captures the noqa behavior, so this seems like a bug in our ruff:ignore handling:

main.py:

x: str = 1  # ty:ignore[invalid-assignment]
x: str = 1  # some comment  # ty:ignore[invalid-assignment]

Playground

This came up while I was working on #25537 and thought of #25414.

[Lawson-Darrow]

Hi @ntBre, I'd like to take this one if it's still up for grabs. Before I write anything: for a comment like # some note # ruff: ignore[F401], should the suppression parser key off the last #-delimited segment (mirroring how noqa uses trimmed.find('#') in directives.rs), and how should it handle a trailing reason after the directive? Want to match your intended semantics for the preview feature rather than guess.

[ntBre]

Sorry for not assigning myself earlier, but I actually have a local branch for this already. Thanks for expressing interest and checking in, though!

[Lawson-Darrow]

No worries!