Autofix non-contextmanager use of `pytest.raises` & friends

[jakkdl]

Summary

Rule request

pytest-dev/pytest#13241 wants to deprecate the use of the callable form of raises, warns and deprecated_call - i.e.

excinfo = pytest.raises(ValueError, int, "hello")
# should be
with pytest.raises(ValueError) as excinfo:
  int("hello")

but in the rare codebase where it's widely used it will be a massive pain to rewrite it manually, so we don't want to deprecate it until there's a good option for autofixing it. I thought ruff would be a good option for supplying this.

It can optionally also handle match, which requires a separate assert when using the callable form:

excinfo = pytest.raises(ValueError, int, "hello")
assert excinfo.match("^invalid literal")
# to
with pytest.raises(ValueError, match="^invalid literal"):
    int("hello")

Rationale

The context-manager form is more readable, easier to extend, and supports additional kwargs. And is not on the verge of being deprecated

Requested uptream in flake8-pytest: m-burst/flake8-pytest-style#331, but it's mostly the autofix we're interested in

[MichaReiser]

I don't see a reason not to add this rule if it is accepted upstream if someone's interested in implementing the rule + fix

[jakkdl]

I don't see a reason not to add this rule if it is accepted upstream if someone's interested in implementing the rule + fix

With upstream, do you mean pytest or flake8-pytest-style?

[MichaReiser]

flake8-pytest-style. The alternative is to make it a Ruff rule