Exceptions aren't logged by EventLogger (dev branch)

[fubar-coder]

It seems that in commit 4528bdb, the MessageFormatter helper function in LoggerExtensions.cs was changed to not include the exception. The ConsoleLogger logs the exception by itself, but the EventLogger doesn't.

[muratg]

@BrennanConroy could you take a look?

[BrennanConroy]

This was an intentional change
@lodejard

[fubar-coder]

It was an intentional change that the exception is not included in the event log?

[lodejard]

Sure, the Exception.ToString should be added to the body. Might want to have two newlines between the message and the exception for readability.

[fubar-coder]

That would cause the ConsoleLogger to output the exception twice - which is not really useful/wanted.

[muratg]

@lodejard did you mean EventLog logger should be changed to include Exception.ToString()?

[lodejard]

Yes

[fubar-coder]

Then I misunderstood you. I'm sorry.

[lodejard]

No problem, what I wrote could have meant either thing. :)

[lodejard]

So we were both right :D