feat: support incompatible_enable_proto_toolchain_resolution#608
Merged
feat: support incompatible_enable_proto_toolchain_resolution#608
Conversation
|
This seems like a bug in rules_proto that the initializer call can't bootstrap because it hits a bazel_features load
thesayyn
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See bazelbuild/rules_proto#213
Changes are visible to end-users: no
It will cause bzlmod users to get rules_proto 6.0.0 in their resolved dependencies, which is technically breaking.
Test plan
Note, we could add automated e2e testing for the
--noincompatible_enable_proto_toolchain_resolutionpath as well - feels like overkill given that the conditional logic is all using upstream helpers