Add aliases for built-in linters #563
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calliecameron
added a commit
to calliecameron/rules_lint
that referenced
this pull request
May 29, 2025
Docs now match the actual usage and the examples, and use Label instead of @@. This is done for all linters except ruff and shellcheck, which are already being done in aspect-build#563.
alexeagle
pushed a commit
that referenced
this pull request
May 29, 2025
Docs now match the actual usage and the examples, and use Label instead of @@. This is done for all linters except ruff and shellcheck, which are already being done in #563.
|
@alexeagle any update on reviewing this? This is the last PR for #551, and also contains the last of the related doc updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are equivalent to the aliases for the built-in formatters, and allow use of these linters without having to use confusing relative repo names that appear to be relative to the user's module, but are actually relative to rules_lint.
Ideally the aliases would be
ruffandshellcheck, but those names are taken by bzl_libraries, hence the 'bin' suffix.Fixes #551.