Skip to content

Bumping thor to minor 1.4 due to CVE #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

crsantos
Copy link
Contributor

@crsantos crsantos commented Jul 23, 2025

What

Due to thor's CVE and this .gemspec being specified to patch it's impossible to bump thor's version.
(original issue).

Also dependabot failed to bump thor in this repo:

Bonus

  • Forced to bump guard to a more recent version.
  • Took the change to update .ruby-version - it should be supported on circleci

This fixes #208.

References

rails/thor#897

Next steps

  • Let me know if I should revert the bump to 0.37.2 or keep it
  • Confirm that tests pass with current ruby versionn

Copy link
Owner

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! I ran the tests locally and I like the version bump 👍

@ashfurrow ashfurrow merged commit e0139d3 into ashfurrow:master Jul 24, 2025
1 check passed
@crsantos crsantos deleted the fix/thor-cve-bump branch July 24, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade thor dependency to version patched for vulnerability
2 participants