Add on_tool_start and on_tool_end callbacks #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachdaniel
reviewed
Jul 22, 2025
lib/ash_ai.ex
Outdated
| @@ -243,10 +315,14 @@ defmodule AshAi do | |||
| lang_chain | |||
| |> LLMChain.add_tools(tools) | |||
| |> then(fn llm_chain -> | |||
| if opts.actor do | |||
| if opts.actor || opts.on_tool_start || opts.on_tool_end do | |||
There was a problem hiding this comment.
lets just remove this conditional. Looking at it, it already has a bug where it only sets the tenant if the actor is present 😓
There was a problem hiding this comment.
we can just always set this context.
zachdaniel
approved these changes
Jul 22, 2025
Remove conditional to prevent bug where tenant isn't set if actor is `nil`. Instead, always pass opts to custom context.
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
on_tool_startandon_tool_endcallbacks tosetup_ash_ai/2. I initially planned on only addingon_tool_startbut decided to also addon_tool_endfor consistency. on_tool_response_created is available via langchain but it's a recent addition and not well documented.Fixes #91.
Contributor checklist
Leave anything that you believe does not apply unchecked.