Add an ISO3166 special case for Kosovo#447
Open
sam-w wants to merge 2 commits intoasaskevich:masterfrom
Open
Conversation
|
Hello guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a special case for the
IsISO3166Alpha2andIsISO3166Alpha3validators for Kosovo.Kosovo declared independence in 2008, but we're still waiting for an official inclusion to the ISO3166 standard. In the meantime many official bodies have begun using the codes
XKandXXK. An example of the prevalence of this unofficial usage is that that iOS listsXKas one of its locale codes.Expected:
IsISO3166Alpha2("XK")returnstrueActual:
falseThis change is