[ATfE] Make use of baremetal compiler_rt profile library #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm/llvm-project#167998 enabled baremetal builds of compiler_rt profile runtime, so replace ATfE downstream minimal profile implementation (proflib.c) with compiler_rt one. proflib.c file is kept to provide the code needed to interface compiler_rt profile library to keep it clear in one place. This depends on adding supported Arm architecture in upstream LLVM runtimes CMake file.
vhscampos
reviewed
Dec 19, 2025
| -DCMAKE_INSTALL_PREFIX=<INSTALL_DIR> | ||
| -DCMAKE_NM=${LLVM_BINARY_DIR}/bin/llvm-nm${CMAKE_EXECUTABLE_SUFFIX} | ||
| -DCMAKE_RANLIB=${LLVM_BINARY_DIR}/bin/llvm-ranlib${CMAKE_EXECUTABLE_SUFFIX} | ||
| -DCMAKE_SYSTEM_NAME=Generic |
Contributor
There was a problem hiding this comment.
Where do all these options come from? Did you base it on something else?
Contributor
Author
There was a problem hiding this comment.
This is the same as compiler_rt invocation for builtins
except that:- it is named compiler-rt-profile
- it turns builtins OFF
- it turns profile library ON and baremetal profile ON
- it depends on builtins and C library
The profile library cannot be built in one go with builtins, because of dependencies: profile needs C library that needs builtins.
Contributor
Author
There was a problem hiding this comment.
I do not know if there is a sensible way to move common part out to avoid duplication - hopefully, someone with more CMake experience can advise.
Contributor
There was a problem hiding this comment.
Maybe you could take all the common arguments and place them into another variable. It's not a major issue anyway, do it only if you want.
Example: the compiler_rt_cmake_args variable
arm-software/embedded/samples/src/cpp-baremetal-semihosting-prof/proflib.c
Outdated
Show resolved
Hide resolved
arm-software/embedded/samples/src/cpp-baremetal-semihosting-prof/proflib.c
Show resolved
Hide resolved
arm-software/embedded/samples/src/cpp-baremetal-semihosting-prof/proflib.c
Show resolved
Hide resolved
arm-software/embedded/samples/src/cpp-baremetal-semihosting-prof/proflib.c
Show resolved
Hide resolved
vhscampos
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project#167998 enabled baremetal builds of compiler_rt profile runtime, so replace ATfE downstream minimal profile implementation (proflib.c) with compiler_rt one.
proflib.c file is kept to provide the code needed to interface compiler_rt profile library to keep it clear in one place.
This depends on adding supported Arm architecture in upstream LLVM runtimes CMake file: llvm/llvm-project#172984