chore: simplify user agent version constraint handling in interceptors #22358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
mmorel-35
force-pushed
the
user-agent-validator
branch
from
fcd67fb to
c16c1f3
Compare
mmorel-35
changed the title
mmorel-35
force-pushed
the
user-agent-validator
branch
from
c16c1f3 to
72d2e61
Compare
mmorel-35
changed the title
mmorel-35
force-pushed
the
user-agent-validator
branch
2 times, most recently
from
c58be4d to
39a6288
Compare
14 tasks
mmorel-35
force-pushed
the
user-agent-validator
branch
4 times, most recently
from
e4e7d67 to
3a967f6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22358 +/- ##
=======================================
Coverage 56.03% 56.04%
=======================================
Files 343 343
Lines 57568 57569 +1
=======================================
+ Hits 32258 32263 +5
+ Misses 22659 22656 -3
+ Partials 2651 2650 -1 ☔ View full report in Codecov by Sentry. |
mmorel-35
force-pushed
the
user-agent-validator
branch
4 times, most recently
from
15bdbc5 to
d2874ae
Compare
Contributor
Author
|
/cc @crenshaw-dev |
mmorel-35
force-pushed
the
user-agent-validator
branch
2 times, most recently
from
aa25e38 to
7fcdf76
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
user-agent-validator
branch
from
7fcdf76 to
c0cf633
Compare
ishitasequeira
approved these changes
Apr 27, 2025
Member
ishitasequeira
left a comment
ishitasequeira
left a comment
There was a problem hiding this comment.
Overall change looks good to me!!
LyhengTep
pushed a commit
to LyhengTep/argo-cd
that referenced
this pull request
May 24, 2025
argoproj#22358) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Lyheng <[email protected]>
tylerrosnett
pushed a commit
to StateFarmIns/argo-cd
that referenced
this pull request
May 27, 2025
argoproj#22358) Signed-off-by: Matthieu MOREL <[email protected]>
chansuke
pushed a commit
to chansuke/argo-cd
that referenced
this pull request
Jun 4, 2025
argoproj#22358) Signed-off-by: Matthieu MOREL <[email protected]>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
argoproj#22358) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: dsuhinin <[email protected]>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
argoproj#22358) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: dsuhinin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
simplify user agent version constraint handling in interceptors