fix(hydrator): don't use manifest-generate-paths (#22039) #22015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22015 +/- ##
==========================================
+ Coverage 55.73% 55.75% +0.02%
==========================================
Files 342 342
Lines 57075 57085 +10
==========================================
+ Hits 31809 31827 +18
+ Misses 22622 22621 -1
+ Partials 2644 2637 -7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Crenshaw <[email protected]>
…t-generate-paths Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev
changed the title
agaudreault
approved these changes
Feb 26, 2025
Member
agaudreault
left a comment
agaudreault
left a comment
There was a problem hiding this comment.
LGTM. Good call on documenting this!
Member
Author
|
/cherry-pick release-2.14 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev
added a commit
that referenced
this pull request
Feb 27, 2025
…#22015) (#22061) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
harshitSkyscanner
pushed a commit
to harshitSkyscanner/argo-cd
that referenced
this pull request
Feb 27, 2025
…goproj#22015) Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Harshit-Bajpai <[email protected]>
chzar
pushed a commit
to chzar/argo-cd
that referenced
this pull request
Mar 3, 2025
…goproj#22015) Signed-off-by: Michael Crenshaw <[email protected]>
kingbj940429
pushed a commit
to kingbj940429/argo-cd
that referenced
this pull request
Mar 4, 2025
…goproj#22015) Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: kingbj0429 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22039
The behavior is flaky, and the unit/e2e tests are prohibitively difficult to write. So I'm relying on using the change internally and noting that "Invalid revision range" disappears from logs after releasing the change.